[PM-6163] Speed up list items command - Only call GetGlobals() when we actually need them #7855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Thank you for your contribution! We've added this to our internal Community PR board for review. |
bitwarden-bot
changed the title
|
Fixed Issues
|
Since we only need it as a backup if accountVaultTimeoutAction is null/undefined, there should be no need to call this function every time. While the overhead may seem trivial at first glance, it can add up to a massive increase in runtime when the function is called repeatedly in quick succession (e.g. when running `bw list items` where it is executed once for every item). In my concrete case this change leads to a 20x speedup.
dani-garcia
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Hey @watzkuh, thanks for your PR! The change looks good, and I've tested and experienced the bw list items time go from 190 seconds to 4 seconds, I'm going to send this PR to QA for some final testing, as soon as it's done I'll merge this.
|
This has gone through QA and is ready to merge, thanks for your contribution! |
|
Is this landed yet? I tested it with a prerelease artifact from 2024.5.0 and am still seeing extremely long |
|
Pretty slow for me too. I notice that i hangs a little bit after it prints out the results, so it's not getting the actual items that are slow. I feel like this is slow as well: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Speed up the CLI list items command (see issue #7742)
Code changes
Since we only need it as a backup if
accountVaultTimeoutActionis null/undefined, there should be no need to call this function every time.While the overhead may seem trivial at first glance, it can add up to a massive increase in runtime when the function is called repeatedly in quick succession (e.g. when running
bw list itemswhere it is executed once for every item).In my concrete case this change leads to a 25x speedup.
Before:
After: