Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-8229] Bump node to 20.13.1-LTS #8078

Merged
merged 6 commits into from
May 30, 2024
Merged

[PM-8229] Bump node to 20.13.1-LTS #8078

merged 6 commits into from
May 30, 2024

Conversation

djsmith85
Copy link
Contributor

@djsmith85 djsmith85 commented Feb 23, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [X] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Needed for when we decide to move to Electron 29

Currently blocking #9424 and #8764

Code changes

  • package.json and package-lock.json:
    • Update engine values to Node 20 and npm 10
    • Replaced pkg with @yao-pkg/pkg
  • .github/workflows/build-cli.yml: Use yao-pkg/pkg and yao-pkg/pkg-fetch which are forks of the original pkg and pkg-fetch packages
  • .nvmrc: Update .nvmrc from v18 to v20

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Feb 23, 2024
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.09%. Comparing base (f6942dd) to head (a0fcc80).

Current head a0fcc80 differs from pull request most recent head 1142478

Please upload reports for the commit 1142478 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8078      +/-   ##
==========================================
- Coverage   28.12%   28.09%   -0.03%     
==========================================
  Files        2395     2435      +40     
  Lines       70628    70504     -124     
  Branches    13208    13135      -73     
==========================================
- Hits        19861    19811      -50     
+ Misses      49193    49154      -39     
+ Partials     1574     1539      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitwarden-bot
Copy link

bitwarden-bot commented Feb 23, 2024

Logo
Checkmarx One – Scan Summary & Details4a0088be-75b5-4ffd-8bd6-01ec218da226

No New Or Fixed Issues Found

@djsmith85 djsmith85 requested review from a team and justindbaur May 8, 2024 20:00
@djsmith85 djsmith85 marked this pull request as ready for review May 17, 2024 11:32
@djsmith85 djsmith85 requested a review from a team as a code owner May 17, 2024 11:32
@djsmith85 djsmith85 changed the title Bump node to 20.11.1-LTS Bump node to 20.13.1-LTS May 17, 2024
@djsmith85 djsmith85 requested review from Hinton and removed request for justindbaur May 17, 2024 11:34
@djsmith85 djsmith85 changed the title Bump node to 20.13.1-LTS [PM-8229] Bump node to 20.13.1-LTS May 17, 2024
@djsmith85 djsmith85 removed the needs-qa Marks a PR as requiring QA approval label May 30, 2024
@djsmith85 djsmith85 merged commit 2015f09 into main May 30, 2024
62 checks passed
@djsmith85 djsmith85 deleted the bump-node-to-next-lts branch May 30, 2024 11:24
djsmith85 added a commit to bitwarden/contributing-docs that referenced this pull request May 30, 2024
With bitwarden/clients#8078 we have bumped Node from V18 to V20
djsmith85 added a commit to bitwarden/contributing-docs that referenced this pull request May 31, 2024
With bitwarden/clients#8078 we have bumped Node from V18 to V20

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants