Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scanning #8079

Merged
merged 7 commits into from
Mar 18, 2024
Merged

Scanning #8079

merged 7 commits into from
Mar 18, 2024

Conversation

withinfocus
Copy link
Contributor

@withinfocus withinfocus commented Feb 23, 2024

Objective

Introduces a new GitHub Actions workflow file, scan.yml, which is designed to perform various types of scans on the codebase. The workflow is triggered on workflow dispatch, push to main, rc, and hotfix-rc branches, and on pull request events. The workflow consists of two main jobs: a Static Application Security Testing (SAST) scan using Checkmarx, and a Quality scan using SonarCloud. Both jobs depend on a check-run job, which is defined in another workflow file.

  • .github/workflows/scan.yml: Introduced a new GitHub Actions workflow which is triggered on workflow dispatch, push events to specific branches, and pull request events. The workflow includes two jobs: a SAST scan using Checkmarx and a Quality scan using SonarCloud. Both jobs depend on a check-run job, which is defined in another workflow file.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.72%. Comparing base (25f89e2) to head (0b7bd43).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8079   +/-   ##
=======================================
  Coverage   25.72%   25.72%           
=======================================
  Files        2270     2270           
  Lines       66351    66351           
  Branches    12464    12464           
=======================================
  Hits        17071    17071           
  Misses      47929    47929           
  Partials     1351     1351           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitwarden-bot
Copy link

bitwarden-bot commented Feb 23, 2024

Logo
Checkmarx One – Scan Summary & Detailsca5320ac-023f-44a9-983d-36323cc53e96

No New Or Fixed Issues Found

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@withinfocus withinfocus marked this pull request as ready for review February 26, 2024 22:19
@withinfocus withinfocus requested a review from a team as a code owner February 26, 2024 22:19
vgrassia
vgrassia previously approved these changes Feb 26, 2024
Hinton
Hinton previously requested changes Feb 27, 2024
Copy link
Member

@Hinton Hinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings doesn't sync with checkmarx.

@withinfocus withinfocus requested review from a team and Hinton March 13, 2024 20:45
@bitwarden bitwarden deleted a comment from sonarcloud bot Mar 13, 2024
@withinfocus withinfocus dismissed Hinton’s stale review March 18, 2024 16:52

Initial testing.

@withinfocus withinfocus merged commit 087d174 into main Mar 18, 2024
17 checks passed
@withinfocus withinfocus deleted the scanner branch March 18, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants