Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-1707] Restrict provider access to items #8265

Merged
merged 22 commits into from
May 7, 2024

Conversation

shane-melton
Copy link
Member

Type of change

- [ ] Bug fix
- [X] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Prevent Providers from accessing their client organization ciphers from the admin console. The providers are still capable of exporting/importing into the client organization. They will just not be able to easily access or modify ciphers from the admin / provider console.

With this change, the Vault filter section was removed for Providers when viewing a client organization as it served little purpose with no items to filter. The search input for filtering collections has been moved to the vault header to keep that functionality and save screen space.

Depends on Server PR: bitwarden/server#3881

Code changes

Described by each commit message.

Screenshots

Access a Client Organization

image

image

Regular Admin Console is unaffected

image

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@shane-melton shane-melton requested review from a team as code owners March 8, 2024 19:42
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 1.56250% with 63 lines in your changes are missing coverage. Please review.

Project coverage is 27.73%. Comparing base (c241aba) to head (acb0421).
Report is 1 commits behind head on main.

❗ Current head acb0421 differs from pull request most recent head 12ec355. Consider uploading reports for the commit 12ec355 to get more accurate results

Files Patch % Lines
...pps/web/src/app/vault/org-vault/vault.component.ts 0.00% 17 Missing ⚠️
...t/org-vault/vault-header/vault-header.component.ts 0.00% 9 Missing ⚠️
...angular/src/vault/components/add-edit.component.ts 0.00% 6 Missing ⚠️
...bulk-delete-dialog/bulk-delete-dialog.component.ts 0.00% 5 Missing ⚠️
...b/src/app/vault/org-vault/attachments.component.ts 0.00% 5 Missing ⚠️
...on/src/admin-console/models/domain/organization.ts 0.00% 5 Missing ⚠️
.../web/src/app/vault/org-vault/add-edit.component.ts 0.00% 4 Missing ⚠️
...rg-vault/collection-access-restricted.component.ts 0.00% 3 Missing ⚠️
...log/bulk-collection-assignment-dialog.component.ts 0.00% 2 Missing ⚠️
...b/src/app/vault/org-vault/collections.component.ts 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8265      +/-   ##
==========================================
- Coverage   27.75%   27.73%   -0.02%     
==========================================
  Files        2419     2419              
  Lines       69915    69947      +32     
  Branches    13013    13023      +10     
==========================================
+ Hits        19402    19403       +1     
- Misses      49012    49043      +31     
  Partials     1501     1501              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitwarden-bot
Copy link

bitwarden-bot commented Mar 8, 2024

Logo
Checkmarx One – Scan Summary & Details9b3004f6-ff9c-4f35-90da-86ca09ffd648

No New Or Fixed Issues Found

Jingo88
Jingo88 previously approved these changes Mar 11, 2024
vincentsalucci
vincentsalucci previously approved these changes Mar 18, 2024
@shane-melton
Copy link
Member Author

shane-melton commented Mar 19, 2024

@Jingo88 During a demo we realized the "New Item" button should be hidden for providers when this feature is enabled so I made that small change to the org vault header component in 71f3655 and 04bc7b7

@shane-melton
Copy link
Member Author

@vincentsalucci I think 43f8e2f worked out pretty nicely to avoid opening the dialog in readonly mode when opened by a provider. If you foresee any problem please let me know!

Jingo88
Jingo88 previously approved these changes May 3, 2024
@shane-melton shane-melton merged commit 3a71322 into main May 7, 2024
56 of 60 checks passed
@shane-melton shane-melton deleted the vault/ac-1707/restrict-provider-access-to-items branch May 7, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants