-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AC-1707] Restrict provider access to items #8265
[AC-1707] Restrict provider access to items #8265
Conversation
… when the feature flag is enabled
…tions that have FC enabled
…ccess feature flag
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8265 +/- ##
==========================================
- Coverage 27.75% 27.73% -0.02%
==========================================
Files 2419 2419
Lines 69915 69947 +32
Branches 13013 13023 +10
==========================================
+ Hits 19402 19403 +1
- Misses 49012 49043 +31
Partials 1501 1501 ☔ View full report in Codecov by Sentry. |
No New Or Fixed Issues Found |
…ccess feature flag is enabled
71f3655
…tProviderAccessFlag
@vincentsalucci I think 43f8e2f worked out pretty nicely to avoid opening the dialog in readonly mode when opened by a provider. If you foresee any problem please let me know! |
Type of change
Objective
Prevent Providers from accessing their client organization ciphers from the admin console. The providers are still capable of exporting/importing into the client organization. They will just not be able to easily access or modify ciphers from the admin / provider console.
With this change, the Vault filter section was removed for Providers when viewing a client organization as it served little purpose with no items to filter. The search input for filtering collections has been moved to the vault header to keep that functionality and save screen space.
Depends on Server PR: bitwarden/server#3881
Code changes
Described by each commit message.
Screenshots
Access a Client Organization
Regular Admin Console is unaffected
Before you submit