[PM-5273] Migrate state in CipherService

[LRNcardozoWDF]

Type of change

- [ ] Bug fix
- [ ] New feature development
- [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Migrate CipherService state to state provider, encryptedCiphers, decryptedCiphers, localData, addEditCipherInfo.

Code changes

• state-definitions.ts: Created key for data
• 35-move-local-data-to-state-provider.spec.ts: Created migrator for localData
• abstractions/cipher.service.ts cipher.service.ts: Added methods to allow access to AddEditCipherInfo. Refactor decrypt method so it could be used by derived state.

Before you submit

• Please add unit tests where it makes sense to do so (encouraged but not required)
• If this change requires a documentation update - notify the documentation team
• If this change has particular deployment requirements - notify the DevOps team
• Ensure that all UI additions follow WCAG AA requirements

[codecov]

Codecov Report

Attention: Patch coverage is 39.41176% with 103 lines in your changes are missing coverage. Please review.

Project coverage is 27.36%. Comparing base (62ed7e5) to head (abea832).

Files	Patch %	Lines
libs/common/src/vault/services/cipher.service.ts	20.40%	76 Missing and 2 partials ⚠️
...mmon/src/vault/services/key-state/ciphers.state.ts	46.66%	8 Missing ⚠️
...r/src/tools/popup/generator/generator.component.ts	0.00%	6 Missing ⚠️
apps/browser/src/popup/app.component.ts	0.00%	3 Missing ⚠️
...angular/src/vault/components/add-edit.component.ts	0.00%	3 Missing ⚠️
...common/src/vault/services/folder/folder.service.ts	33.33%	2 Missing ⚠️
...vault/popup/components/vault/add-edit.component.ts	0.00%	1 Missing ⚠️
libs/common/src/platform/models/domain/account.ts	0.00%	1 Missing ⚠️
libs/common/src/vault/models/data/cipher.data.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8314      +/-   ##
==========================================
+ Coverage   27.30%   27.36%   +0.05%     
==========================================
  Files        2341     2343       +2     
  Lines       68379    68418      +39     
  Branches    12785    12787       +2     
==========================================
+ Hits        18669    18720      +51     
+ Misses      48309    48296      -13     
- Partials     1401     1402       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bitwarden-bot]

Checkmarx One – Scan Summary & Details – a352c66f-d22c-4ebd-9fd6-39c58443fe1c

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	Angular_Improper_Type_Pipe_Usage	/apps/browser/src/vault/popup/components/fido2/fido2-use-browser-link.component.html: 1	Attack Vector
	Angular_Improper_Type_Pipe_Usage	/apps/web/src/app/billing/shared/adjust-storage.component.html: 27	Attack Vector
	Angular_Improper_Type_Pipe_Usage	/apps/web/src/app/billing/organizations/adjust-subscription.component.html: 54	Attack Vector
	Angular_Improper_Type_Pipe_Usage	/apps/web/src/app/billing/organizations/adjust-subscription.component.html: 18	Attack Vector
	Client_Privacy_Violation	/apps/browser/src/background/runtime.background.ts: 331	Attack Vector
	Client_Privacy_Violation	/apps/browser/src/auth/popup/account-switching/account.component.ts: 12	Attack Vector
	Client_Privacy_Violation	/apps/browser/src/auth/popup/account-switching/account.component.ts: 12	Attack Vector
	Client_Privacy_Violation	/apps/web/src/app/auth/settings/two-factor-verify.component.html: 3	Attack Vector
	Client_Privacy_Violation	/libs/components/src/color-password/color-password.component.ts: 25	Attack Vector
	Client_Privacy_Violation	/libs/components/src/color-password/color-password.component.ts: 26	Attack Vector
	Client_Privacy_Violation	/apps/desktop/src/auth/lock.component.html: 32	Attack Vector
	Client_Privacy_Violation	/apps/web/src/app/auth/lock.component.html: 18	Attack Vector
	Client_Privacy_Violation	/apps/web/src/app/billing/shared/add-credit.component.ts: 80	Attack Vector
	Client_Privacy_Violation	/apps/web/src/app/billing/shared/add-credit.component.ts: 30	Attack Vector
	Client_Privacy_Violation	/apps/web/src/app/billing/shared/add-credit.component.ts: 135	Attack Vector
	Client_Privacy_Violation	/apps/web/src/app/billing/shared/add-credit.component.ts: 146	Attack Vector
	Client_Privacy_Violation	/apps/web/src/app/billing/shared/add-credit.component.ts: 70	Attack Vector
	Client_DOM_Open_Redirect	/apps/desktop/src/auth/accessibility-cookie.component.html: 18	Attack Vector
	Client_DOM_Open_Redirect	/apps/browser/src/tools/popup/generator/password-generator-history.component.ts: 18	Attack Vector
	Client_DOM_Open_Redirect	/apps/browser/src/auth/popup/account-switching/account.component.ts: 25	Attack Vector
	Client_DOM_Open_Redirect	/apps/browser/src/auth/popup/login-via-auth-request.component.ts: 54	Attack Vector
	Client_DOM_Open_Redirect	/apps/desktop/src/auth/login/login-via-auth-request.component.ts: 62	Attack Vector
	Client_DOM_Open_Redirect	/apps/browser/src/auth/popup/account-switching/current-account.component.ts: 31	Attack Vector
	Client_DOM_Open_Redirect	/apps/browser/src/auth/popup/login-via-auth-request.component.ts: 54	Attack Vector
	Client_DOM_Open_Redirect	/apps/desktop/src/auth/login/login-via-auth-request.component.ts: 62	Attack Vector
	Client_DOM_Open_Redirect	/apps/browser/src/vault/popup/components/vault/password-history.component.ts: 21	Attack Vector
	Client_DOM_Open_Redirect	/apps/browser/src/vault/popup/components/vault/attachments.component.ts: 32	Attack Vector
	Client_DOM_Open_Redirect	/apps/browser/src/popup/settings/premium.component.ts: 27	Attack Vector
	Client_Hardcoded_Domain	/apps/web/src/app/billing/shared/payment.component.ts: 56	Attack Vector
	Client_Hardcoded_Domain	/apps/web/src/app/billing/shared/payment.component.ts: 56	Attack Vector

[cagonzalezcs]

Things are looking solid from my side, though the CipherService, FolderService, and CipherStateService classes seem to be missing Jest test coverage in a number of places. It'd be nice to address that, though I won't block the ticket for it.

Let me know if you need any further review on this.

[audreyality]

The requested change I asked for is implemented. There's still a nit (I left it unresolved above), but it's not blocking.

It's been approved by another Vault's team member.