Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM 4972] change kdf confirmation component migration #8489

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vinith-kovan
Copy link
Collaborator

@vinith-kovan vinith-kovan commented Mar 26, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [X] Other

Objective

Migrate the kdf confirmation component to use the component library.

Code changes

change-kdf-confirmation.component.html: Updated the form, inputs to use the equivalent components from the Component Library.
change-kdf-confirmation.component.ts: Updated the submit function to arrow function.

Screenshots

Before Migration:
image

After Migration:
image

@vinith-kovan vinith-kovan requested a review from a team as a code owner March 26, 2024 12:30
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 26.36%. Comparing base (da14d01) to head (7ab93ce).
Report is 2 commits behind head on main.

Files Patch % Lines
...ty/change-kdf/change-kdf-confirmation.component.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8489      +/-   ##
==========================================
+ Coverage   26.34%   26.36%   +0.02%     
==========================================
  Files        2302     2303       +1     
  Lines       67373    67382       +9     
  Branches    12636    12638       +2     
==========================================
+ Hits        17749    17768      +19     
+ Misses      48241    48232       -9     
+ Partials     1383     1382       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Change kdf configuration component migration
@vinith-kovan vinith-kovan force-pushed the PM-4972-Migrate-change-kdf-confirmation-component branch from b5f9c85 to 7ab93ce Compare March 26, 2024 15:21
@jlf0dev jlf0dev requested review from jlf0dev and removed request for JaredSnider-Bitwarden May 8, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants