[SM-1168] Update access policy selector to disable on submit #8519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8519 +/- ##
==========================================
- Coverage 27.70% 27.69% -0.01%
==========================================
Files 2392 2392
Lines 69368 69375 +7
Branches 12938 12938
==========================================
Hits 19215 19215
- Misses 48673 48680 +7
Partials 1480 1480 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
coltonhurst
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
The purpose of this PR is to update usage of the access policy selector to disable the form on submit and make loading more consistent with other tabs.
Code changes
bitwarden_license/bit-web/src/app/secrets-manager/projects/project/project-people.component.html:
Add spinner
bitwarden_license/bit-web/src/app/secrets-manager/projects/project/project-people.component.ts:
Fix floating promises.
Disable the form group on submit.
bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/people/service-account-people.component.html:
Add spinner
bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/people/service-account-people.component.ts:
Fix floating promises.
Remove catch error since this is now covered by
serviceAccountAccessGuardDisable the form group on submit.
bitwarden_license/bit-web/src/app/secrets-manager/shared/access-policies/access-policy-selector/access-policy-selector.component.html:
Add disabled to required fields.
Screenshots
Before Project → People load in
After Project → People load in
Before Project → People submit
After Project → People submit
Before Service Account → People load in
After Service Account → People load in
Before Service Account → People submit
After Service Account → People submit
Before you submit