Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PM-6113] build rust authenticator and client to support i os and android passkey provider implementation #8528

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from
Draft

[PM-6113] build rust authenticator and client to support i os and android passkey provider implementation #8528

wants to merge 25 commits into from

Conversation

coroiu
Copy link
Contributor

@coroiu coroiu commented Mar 28, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

Hinton and others added 25 commits April 10, 2023 11:14
@Hinton
Experimenting with WASM
97f177f
@Hinton
Merge branch 'master' of github.com:bitwarden/clients into ps/wasm
2de80d0 
# Conflicts:
#	apps/web/tsconfig.json
#	tsconfig.json
@Hinton
Add fingerprint from sdk
c9cfc83
@Hinton
Merge branch 'master' of github.com:bitwarden/clients into ps/wasm
be47b80
@Hinton
Rollback changes to security-keys.
2ba945d
@Hinton
Move service to common
29f604a
@Hinton
Merge branch 'master' of github.com:bitwarden/clients into ps/wasm
4ee693e 
# Conflicts:
#	package-lock.json
#	package.json
@Hinton
Rename device type and kdf type
e2ece96
@Hinton
Cleanup package lock
6802c59
@Hinton
Refactor fingerprint dialog to use the new dialog system
32fff1e
@Hinton
Add support for sdk in browser
62d1a42
@Hinton
Use sdk in desktop
455e655
@Hinton
Add support for the cli
a9c3324
@Hinton
Merge branch 'master' of github.com:bitwarden/clients into ps/wasm
3924bd9 
# Conflicts:
#	apps/browser/src/background/main.background.ts
#	apps/browser/src/popup/services/services.module.ts
#	apps/browser/src/popup/settings/settings.component.ts
#	apps/cli/src/bw.ts
#	apps/cli/src/commands/get.command.ts
#	apps/desktop/src/app/app.component.ts
#	apps/web/src/app/settings/profile.component.ts
#	libs/angular/src/services/jslib-services.module.ts
#	package.json
@Hinton
Merge branch 'master' of github.com:bitwarden/clients into ps/wasm
7e0d9c0 
# Conflicts:
#	apps/browser/src/background/main.background.ts
#	apps/browser/src/popup/settings/settings.component.ts
#	apps/cli/src/bw.ts
#	apps/cli/src/commands/get.command.ts
#	apps/cli/src/commands/serve.command.ts
#	apps/cli/src/tools/send/send.program.ts
#	apps/cli/src/vault.program.ts
#	apps/desktop/src/app/app.component.ts
#	apps/web/tsconfig.json
#	libs/angular/src/services/jslib-services.module.ts
#	libs/shared/tsconfig.libs.json
#	package-lock.json
#	tsconfig.json
@Hinton
Remove importer
ca96be9
@coroiu
Merge branch 'main' into ps/wasm
f11d441
@coroiu
Merge branch 'main' into ps/wasm
68fad9e
@coroiu
fix: fingerprint
7549221
@coroiu
fix(browser): argon2 wasm bundle issues
2e227a2
@coroiu
feat: redirect fido2 calls to sdk
140fad2
@coroiu
feat: first working UI interaction
2d864bb
@coroiu
[PM-6113] feat: support credential creation (saving not yet implemented)
3c24c3d
@coroiu
[PM-6113] feat: successfully save credential created by the SDK
9520ab3
@coroiu
[PM-6113] chore: re-add assertion part of TS implementation
2ad3597
@github-actions GitHub Actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details – fe116871-6f86-4787-9d36-0f4bcf57419c

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Client_Privacy_Violation /apps/browser/src/background/runtime.background.ts: 317 Attack Vector
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1149 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-browser.yml: 412 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /release-web.yml: 133 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 282 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1224 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-web.yml: 263 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-web.yml: 293 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-web.yml: 357 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 388 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-auto-bump.yml: 47 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-web.yml: 187 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 138 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 131 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-browser.yml: 354 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Client_DOM_Open_Redirect /apps/desktop/src/auth/accessibility-cookie.component.html: 18 Attack Vector
LOW Client_JQuery_Deprecated_Symbols /libs/common/src/autofill/services/autofill-settings.service.ts: 150 Attack Vector
LOW Client_Use_Of_Iframe_Without_Sandbox /apps/browser/src/autofill/content/notification-bar.ts: 888 Attack Vector
LOW Unprotected_Cookie /apps/web/src/app/auth/two-factor.component.ts: 132 Attack Vector
LOW Unsafe_Use_Of_Target_blank /apps/desktop/src/auth/accessibility-cookie.component.ts: 92 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 17 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 40 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 53 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 42 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 62 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 31 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 44 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 46 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 22 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 37 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 49 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 22 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 17 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 39 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 38 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 25 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 14 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 36 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 13 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 48 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 38 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 57 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 47 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 19 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 35 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 51 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 38 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 66 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 33 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 20 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 15 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 62 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 56 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 26 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 61 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 13 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 41 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 33 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 66 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 45 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 63 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 17 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 55 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 37 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 40 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 28 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 43 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 56 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 64 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 31 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 24 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 21 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 28 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 63 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 24 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 20 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 47 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 52 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 46 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 66 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 44 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 16 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 39 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 23 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 20 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 23 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 19 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 13 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 15 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 54 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 54 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 61 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 53 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 43 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 52 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 65 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/platform/services/i18n.service.ts: 18 Attack Vector
LOW

More results are available on AST platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@coroiu @Hinton