-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-7169][PM-5267] Remove auth status from account info #8539
[PM-7169][PM-5267] Remove auth status from account info #8539
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
768a03f
to
9ce6d0c
Compare
Fixup missed factories
…uth-status-from-account-info
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8539 +/- ##
==========================================
- Coverage 27.20% 27.19% -0.02%
==========================================
Files 2339 2339
Lines 68267 68261 -6
Branches 12749 12748 -1
==========================================
- Hits 18570 18561 -9
- Misses 48301 48303 +2
- Partials 1396 1397 +1 ☔ View full report in Codecov by Sentry. |
8dad486
to
cd8d8ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
macOS build had failed, re-ran the job and it passed so it was probably nothing :)
…uth-status-from-account-info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests failing
…uth-status-from-account-info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! What he said about conflicts^
…uth-status-from-account-info
have to close and reopen to bump the enforce pr labels to reevaluate 🙄 |
Type of change
Objective
Adding authentication status to account service has proven to be a mistake. It's better handled as an on-demand check, which is introduced by #8537.
This removes the status from account service entirely, including any current calls to it and set methods.
Before you submit