Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7169][PM-5267] Remove auth status from account info #8539

Merged
merged 18 commits into from
Apr 12, 2024

Conversation

MGibson1
Copy link
Member

@MGibson1 MGibson1 commented Mar 28, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Adding authentication status to account service has proven to be a mistake. It's better handled as an on-demand check, which is introduced by #8537.

This removes the status from account service entirely, including any current calls to it and set methods.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

This comment was marked as off-topic.

@MGibson1 MGibson1 changed the title Auth/pm-7169/remove-auth-status-from-account-info Remove auth status from account info Apr 1, 2024
Base automatically changed from auth/pm-7170/observable-token-and-auth-status to main April 1, 2024 19:15
@MGibson1 MGibson1 changed the title Remove auth status from account info [PM-7169] Remove auth status from account info Apr 1, 2024
@MGibson1 MGibson1 force-pushed the auth/pm-7169/remove-auth-status-from-account-info branch from 768a03f to 9ce6d0c Compare April 1, 2024 20:00
@MGibson1 MGibson1 marked this pull request as ready for review April 1, 2024 20:03
@MGibson1 MGibson1 requested review from a team as code owners April 1, 2024 20:03
@MGibson1 MGibson1 requested review from coroiu and jlf0dev April 1, 2024 20:03
@MGibson1 MGibson1 marked this pull request as draft April 1, 2024 20:03
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 31.37255% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 27.19%. Comparing base (b843aa6) to head (3288ae1).

Files Patch % Lines
...pps/browser/src/platform/popup/header.component.ts 0.00% 7 Missing ⚠️
...up/account-switching/account-switcher.component.ts 0.00% 6 Missing ⚠️
.../common/src/services/event/event-upload.service.ts 0.00% 6 Missing ⚠️
apps/browser/src/popup/app.component.ts 0.00% 4 Missing ⚠️
libs/angular/src/auth/guards/unauth.guard.ts 0.00% 4 Missing ⚠️
...pup/account-switching/current-account.component.ts 0.00% 3 Missing ⚠️
...mon/src/services/event/event-collection.service.ts 0.00% 3 Missing ⚠️
...unt-switching/services/account-switcher.service.ts 85.71% 0 Missing and 1 partial ⚠️
libs/common/src/platform/services/state.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8539      +/-   ##
==========================================
- Coverage   27.20%   27.19%   -0.02%     
==========================================
  Files        2339     2339              
  Lines       68267    68261       -6     
  Branches    12749    12748       -1     
==========================================
- Hits        18570    18561       -9     
- Misses      48301    48303       +2     
- Partials     1396     1397       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MGibson1 MGibson1 marked this pull request as ready for review April 1, 2024 22:25
@MGibson1 MGibson1 force-pushed the auth/pm-7169/remove-auth-status-from-account-info branch from 8dad486 to cd8d8ea Compare April 1, 2024 22:50
coroiu
coroiu previously approved these changes Apr 2, 2024
Copy link
Contributor

@coroiu coroiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macOS build had failed, re-ran the job and it passed so it was probably nothing :)

@MGibson1 MGibson1 added the needs-qa Marks a PR as requiring QA approval label Apr 2, 2024
@MGibson1 MGibson1 requested a review from coroiu April 3, 2024 19:26
Copy link
Contributor

@coroiu coroiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests failing

audreyality
audreyality previously approved these changes Apr 9, 2024
coroiu
coroiu previously approved these changes Apr 9, 2024
@MGibson1 MGibson1 dismissed stale reviews from coroiu and audreyality via 90cbad3 April 9, 2024 17:24
audreyality
audreyality previously approved these changes Apr 9, 2024
coroiu
coroiu previously approved these changes Apr 10, 2024
Copy link
Contributor

@coroiu coroiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to get stop notifications, just ping me again if my approval gets dismissed during the conflict resolution.

(yes I did spent too much time creating that meme image 🥲)

Copy link
Member

@jlf0dev jlf0dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! What he said about conflicts^

@MGibson1 MGibson1 dismissed stale reviews from coroiu and audreyality via 69336e6 April 11, 2024 15:17
@MGibson1 MGibson1 removed the needs-qa Marks a PR as requiring QA approval label Apr 11, 2024
@MGibson1 MGibson1 enabled auto-merge (squash) April 11, 2024 15:26
@MGibson1
Copy link
Member Author

have to close and reopen to bump the enforce pr labels to reevaluate 🙄

@MGibson1 MGibson1 closed this Apr 11, 2024
auto-merge was automatically disabled April 11, 2024 15:38

Pull request was closed

@MGibson1 MGibson1 reopened this Apr 11, 2024
@MGibson1 MGibson1 enabled auto-merge (squash) April 11, 2024 15:39
@MGibson1 MGibson1 merged commit 8d698d9 into main Apr 12, 2024
110 of 113 checks passed
@MGibson1 MGibson1 deleted the auth/pm-7169/remove-auth-status-from-account-info branch April 12, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants