Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM 2164] api-key component migration #8562

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

vinith-kovan
Copy link
Collaborator

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [X] Other

Objective

Migrate the api key component to use the component library.

Code changes

account.component.ts: updated the viewApiKey and rotateApiKey methods to use the dialog open method on the ApiKeyComponent class.
security-keys.component.ts: updated the viewApiKey and rotateApiKey methods to use the dialog open method on the ApiKeyComponent class.
api-key.component.ts: Refactored the submit method and added a static open method to the ApiKeyComponent class to make it easier to open the dialog.
api-key.component.html: Updated the form, inputs, and dialog to use the equivalent components from the Component Library.

Screenshots

api-keys.-.Made.with.Clipchamp.mp4

@vinith-kovan vinith-kovan requested review from a team as code owners April 1, 2024 10:20
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Apr 1, 2024
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 29.16667% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 27.33%. Comparing base (2c88556) to head (61d2139).

Files Patch % Lines
...rc/app/auth/settings/security/api-key.component.ts 29.41% 11 Missing and 1 partial ⚠️
.../auth/settings/security/security-keys.component.ts 25.00% 3 Missing ⚠️
...onsole/organizations/settings/account.component.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8562      +/-   ##
==========================================
+ Coverage   27.32%   27.33%   +0.01%     
==========================================
  Files        2349     2349              
  Lines       68613    68585      -28     
  Branches    12828    12829       +1     
==========================================
+ Hits        18748    18750       +2     
+ Misses      48455    48425      -30     
  Partials     1410     1410              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Apr 1, 2024

Logo
Checkmarx One – Scan Summary & Detailsfa20acfb-b422-44ab-8a07-69217fb95232

No New Or Fixed Issues Found

eliykat
eliykat previously approved these changes Apr 3, 2024
Copy link
Member

@eliykat eliykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AC changes look good, thanks for handling!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants