New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM 2164] api-key component migration #8562
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8562 +/- ##
==========================================
+ Coverage 27.32% 27.33% +0.01%
==========================================
Files 2349 2349
Lines 68613 68585 -28
Branches 12828 12829 +1
==========================================
+ Hits 18748 18750 +2
+ Misses 48455 48425 -30
Partials 1410 1410 ☔ View full report in Codecov by Sentry. |
No New Or Fixed Issues Found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AC changes look good, thanks for handling!
…164-Migrate-api-key-dialog
…164-Migrate-api-key-dialog
…164-Migrate-api-key-dialog
…164-Migrate-api-key-dialog
Type of change
Objective
Migrate the api key component to use the component library.
Code changes
account.component.ts: updated the viewApiKey and rotateApiKey methods to use the dialog open method on the ApiKeyComponent class.
security-keys.component.ts: updated the viewApiKey and rotateApiKey methods to use the dialog open method on the ApiKeyComponent class.
api-key.component.ts: Refactored the submit method and added a static open method to the ApiKeyComponent class to make it easier to open the dialog.
api-key.component.html: Updated the form, inputs, and dialog to use the equivalent components from the Component Library.
Screenshots
api-keys.-.Made.with.Clipchamp.mp4