PM 2048 Update Two Factor Options dialog #8565

KiruthigaManivannan · 2024-04-01T12:43:12Z

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [x] Other

Objective

Update the Two Factor Options component to use the component library.

Code changes

two-factor-options.component.html: Updated modal to use bit-dialog from component library
two-factor-options.component.ts Dialog open method logic implemented
two-factor.component.ts During Another method link click , Two factor options dialog open called.
two-factor.component.html Removed ng-template

Screenshots

2048-Twofactoroptions.mp4

…048-update-two-factor-options-dialog

codecov · 2024-04-01T12:50:15Z

Codecov Report

Attention: Patch coverage is 36.84211% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 26.80%. Comparing base (2e51d96) to head (a3d0333).

Files	Patch %	Lines
...s/web/src/app/auth/two-factor-options.component.ts	40.00%	6 Missing ⚠️
apps/web/src/app/auth/two-factor.component.ts	33.33%	5 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8565   +/-   ##
=======================================
  Coverage   26.80%   26.80%           
=======================================
  Files        2308     2308           
  Lines       67393    67405   +12     
  Branches    12630    12633    +3     
=======================================
+ Hits        18063    18069    +6     
- Misses      47940    47944    +4     
- Partials     1390     1392    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-04-01T13:20:10Z

Checkmarx One – Scan Summary & Details – 13f7af4e-dff5-4e85-a54a-3b9c0b7a4e34

New Issues

Issue	Source File / Package	Checkmarx Insight
Client_DOM_Code_Injection	/apps/web/src/connectors/common.ts: 2	Attack Vector
Client_DOM_XSS	/apps/browser/src/auth/scripts/duo.js: 285	Attack Vector
Client_DOM_XSS	/apps/desktop/src/auth/scripts/duo.js: 285	Attack Vector

Fixed Issues

Severity	Issue	Source File / Package
	Client_DOM_Code_Injection	/apps/browser/src/autofill/services/collect-autofill-content.service.ts: 1051
	Client_DOM_Stored_XSS	/apps/web/src/connectors/sso.ts: 33
	Client_DOM_XSS	/apps/web/src/connectors/common.ts: 2
	Client_DOM_XSS	/apps/web/src/connectors/common.ts: 2
	Client_DOM_XSS	/apps/web/src/connectors/common.ts: 2
	Client_DOM_XSS	/apps/web/src/connectors/common.ts: 2
	Client_DOM_XSS	/apps/web/src/connectors/sso.ts: 21
	Client_DOM_XSS	/apps/web/src/connectors/sso.ts: 19
	Client_DOM_XSS	/apps/web/src/connectors/sso.ts: 15
	Client_DOM_XSS	/apps/web/src/app/auth/settings/two-factor-verify.component.html: 3
	Client_DOM_XSS	/bitwarden_license/bit-web/src/app/admin-console/providers/settings/account.component.html: 27
	Client_DOM_XSS	/bitwarden_license/bit-web/src/app/admin-console/providers/settings/account.component.html: 27
	Absolute_Path_Traversal	/apps/cli/src/commands/serve.command.ts: 309
	Absolute_Path_Traversal	/apps/cli/src/commands/serve.command.ts: 341
	Absolute_Path_Traversal	/apps/cli/src/commands/serve.command.ts: 341
	Absolute_Path_Traversal	/apps/cli/src/commands/serve.command.ts: 309
	Angular_Improper_Type_Pipe_Usage	/apps/browser/src/vault/popup/components/fido2/fido2-use-browser-link.component.html: 1
	Angular_Improper_Type_Pipe_Usage	/apps/web/src/app/billing/shared/adjust-storage.component.html: 27
	Angular_Improper_Type_Pipe_Usage	/apps/web/src/app/billing/organizations/adjust-subscription.component.html: 54
	Angular_Improper_Type_Pipe_Usage	/apps/web/src/app/billing/organizations/adjust-subscription.component.html: 18
	Client_Potential_XSS	/apps/desktop/src/app/components/avatar.component.ts: 45
	Client_Potential_XSS	/libs/components/src/avatar/avatar.component.ts: 48
	Client_Potential_XSS	/apps/desktop/src/app/components/avatar.component.ts: 45
	Client_Privacy_Violation	/apps/browser/src/background/runtime.background.ts: 331
	Client_Privacy_Violation	/apps/web/src/app/tools/reports/pages/breach-report.component.html: 14
	Client_Privacy_Violation	/apps/browser/src/auth/popup/account-switching/account.component.ts: 12
	Client_Privacy_Violation	/apps/browser/src/auth/popup/account-switching/account.component.ts: 12
	Client_Privacy_Violation	/apps/browser/src/auth/popup/account-switching/account.component.ts: 12
	Client_Privacy_Violation	/apps/web/src/app/auth/settings/two-factor-verify.component.html: 3
	Client_Privacy_Violation	/libs/components/src/color-password/color-password.component.ts: 25
	Client_Privacy_Violation	/libs/components/src/color-password/color-password.component.ts: 26
	Client_Privacy_Violation	/apps/desktop/src/auth/lock.component.html: 32
	Client_Privacy_Violation	/apps/web/src/app/auth/lock.component.html: 18
	Client_Privacy_Violation	/apps/web/src/app/billing/shared/add-credit.component.ts: 30
	Client_Privacy_Violation	/apps/web/src/app/billing/shared/add-credit.component.ts: 146
	Client_Privacy_Violation	/apps/web/src/app/billing/shared/add-credit.component.ts: 70
	Client_Privacy_Violation	/apps/web/src/app/billing/shared/add-credit.component.ts: 80
	Client_Privacy_Violation	/apps/web/src/app/billing/shared/add-credit.component.ts: 135
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/auth/sso/sso.component.ts: 161
	Client_Privacy_Violation	/bitwarden_license/bit-web/src/app/auth/sso/sso.component.ts: 161
	Client_Privacy_Violation	/apps/web/src/connectors/webauthn-fallback.ts: 116
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 534
	Client_Privacy_Violation	/apps/web/src/app/billing/shared/add-credit.component.html: 46
	Client_Privacy_Violation	/apps/web/src/app/auth/recover-two-factor.component.html: 37
	Client_Privacy_Violation	/apps/desktop/src/auth/lock.component.html: 32
	Client_Privacy_Violation	/apps/web/src/app/auth/lock.component.html: 18
	Client_Privacy_Violation	/libs/components/src/color-password/color-password.component.ts: 14
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 60
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 56
	Client_Privacy_Violation	/apps/browser/src/tools/popup/generator/password-generator-history.component.html: 26
	Client_Privacy_Violation	/apps/browser/src/vault/popup/components/vault/password-history.component.html: 18
	Client_Privacy_Violation	/apps/desktop/src/app/tools/password-generator-history.component.html: 15
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/password-history.component.html: 12
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/view.component.html: 50
	Client_Privacy_Violation	/libs/components/src/color-password/color-password.component.ts: 14
	Client_Privacy_Violation	/apps/browser/src/tools/popup/generator/password-generator-history.component.html: 26
	Client_Privacy_Violation	/apps/browser/src/vault/popup/components/vault/password-history.component.html: 18
	Client_Privacy_Violation	/apps/desktop/src/app/tools/password-generator-history.component.html: 15
	Client_Privacy_Violation	/apps/desktop/src/vault/app/vault/password-history.component.html: 12
	Host Namespace is Shared	/docker-compose.yml: 4
	Missing_HSTS_Header	/apps/cli/src/auth/commands/login.command.ts: 705
	Networks Not Set	/docker-compose.yml: 4
	SSRF	/libs/importer/src/importers/lastpass/access/services/rest-client.ts: 69
	SSRF	/libs/importer/src/importers/lastpass/access/services/rest-client.ts: 69
	Angular_Usage_of_Unsafe_DOM_Sanitizer	/libs/components/src/avatar/avatar.component.ts: 80
	Angular_Usage_of_Unsafe_DOM_Sanitizer	/apps/desktop/src/app/components/avatar.component.ts: 75
	Angular_Usage_of_Unsafe_DOM_Sanitizer	/libs/components/src/icon/icon.component.ts: 18
	Angular_Usage_of_Unsafe_DOM_Sanitizer	/libs/components/src/icon/icon.component.ts: 18
	Client_DOM_Open_Redirect	/apps/desktop/src/auth/accessibility-cookie.component.html: 18
	Client_DOM_Open_Redirect	/apps/web/src/connectors/common.ts: 2
	Client_DOM_Open_Redirect	/apps/web/src/connectors/common.ts: 2
	Client_DOM_Open_Redirect	/apps/web/src/connectors/common.ts: 2
	Client_DOM_Open_Redirect	/apps/web/src/connectors/sso.ts: 21
	Client_DOM_Open_Redirect	/apps/web/src/connectors/common.ts: 2
	Client_DOM_Open_Redirect	/apps/web/src/connectors/sso.ts: 19
	Client_DOM_Open_Redirect	/apps/web/src/connectors/common.ts: 2
	Client_DOM_Open_Redirect	/apps/web/src/connectors/sso.ts: 15
	Client_DOM_Open_Redirect	/apps/browser/src/tools/popup/generator/password-generator-history.component.ts: 18
	Client_DOM_Open_Redirect	/apps/browser/src/auth/popup/account-switching/current-account.component.ts: 30
	Client_DOM_Open_Redirect	/apps/browser/src/auth/popup/login-via-auth-request.component.ts: 52
	Client_DOM_Open_Redirect	/apps/browser/src/auth/popup/login-via-auth-request.component.ts: 52
	Client_DOM_Open_Redirect	/apps/desktop/src/auth/login/login-via-auth-request.component.ts: 60
	Client_DOM_Open_Redirect	/apps/desktop/src/auth/login/login-via-auth-request.component.ts: 60
	Client_DOM_Open_Redirect	/apps/browser/src/auth/popup/login-via-auth-request.component.ts: 52
	Client_DOM_Open_Redirect	/apps/browser/src/auth/popup/login-via-auth-request.component.ts: 52
	Client_DOM_Open_Redirect	/apps/desktop/src/auth/login/login-via-auth-request.component.ts: 60
	Client_DOM_Open_Redirect	/apps/desktop/src/auth/login/login-via-auth-request.component.ts: 60
	Client_DOM_Open_Redirect	/apps/browser/src/auth/popup/account-switching/account.component.ts: 25
	Client_DOM_Open_Redirect	/apps/browser/src/vault/popup/components/vault/password-history.component.ts: 21
	Client_DOM_Open_Redirect	/apps/browser/src/vault/popup/components/vault/attachments.component.ts: 32
	Client_DOM_Open_Redirect	/apps/browser/src/popup/settings/premium.component.ts: 27
	Client_DOM_Open_Redirect	/libs/common/src/auth/iframe-component.ts: 49
	Client_DOM_Open_Redirect	/apps/browser/src/auth/scripts/duo.js: 277
	Client_DOM_Open_Redirect	/apps/browser/src/auth/scripts/duo.js: 277
	Client_DOM_Open_Redirect	/apps/desktop/src/auth/scripts/duo.js: 277
	Client_DOM_Open_Redirect	/apps/desktop/src/auth/scripts/duo.js: 277
	Client_DOM_Open_Redirect	/libs/common/src/auth/webauthn-iframe.ts: 25
	Client_DOM_Open_Redirect	/apps/desktop/src/auth/scripts/duo.js: 277
	Client_DOM_Open_Redirect	/apps/desktop/src/auth/scripts/duo.js: 277
	Client_DOM_Open_Redirect	/apps/browser/src/auth/scripts/duo.js: 277
	Client_DOM_Open_Redirect	/apps/browser/src/auth/scripts/duo.js: 277
	Client_DOM_Open_Redirect	/apps/desktop/src/auth/scripts/duo.js: 277
	Client_DOM_Open_Redirect	/apps/desktop/src/auth/scripts/duo.js: 277
	Client_DOM_Open_Redirect	/apps/browser/src/auth/scripts/duo.js: 277
	Client_DOM_Open_Redirect	/apps/browser/src/auth/scripts/duo.js: 277
	Client_DOM_Open_Redirect	/libs/common/src/auth/webauthn-iframe.ts: 25
	Client_DOM_Open_Redirect	/apps/desktop/src/auth/scripts/duo.js: 277
	Client_DOM_Open_Redirect	/apps/desktop/src/auth/scripts/duo.js: 277
	Client_DOM_Open_Redirect	/apps/browser/src/auth/scripts/duo.js: 277
	Client_DOM_Open_Redirect	/apps/browser/src/auth/scripts/duo.js: 277
	Client_Hardcoded_Domain	/apps/web/src/app/billing/shared/payment.component.ts: 56
	Client_Hardcoded_Domain	/apps/web/src/app/billing/shared/payment.component.ts: 56
	Client_Hardcoded_Domain	/apps/web/src/connectors/captcha.ts: 57
	Client_Password_In_Comment	/libs/angular/src/vault/components/add-edit.component.ts: 663
	Client_Password_In_Comment	/apps/web/src/app/vault/org-vault/add-edit.component.ts: 108
	Client_Password_In_Comment	/apps/web/src/app/vault/org-vault/collections.component.ts: 45
	Client_Password_In_Comment	/libs/angular/src/platform/utils/safe-provider.ts: 92
	Client_Password_In_Comment	/libs/common/src/state-migrations/migrations/30-move-policy-state-to-state-provider.ts: 13
	Client_Password_In_Comment	/apps/browser/src/autofill/background/notification.background.ts: 555
	Client_Password_In_Comment	/libs/common/src/services/event/event-collection.service.ts: 93
	Client_Password_In_Comment	/libs/common/src/services/event/event-collection.service.ts: 88
	Client_Password_In_Comment	/libs/common/src/platform/biometrics/biometric-state.service.ts: 62
	Client_Password_In_Comment	/libs/common/src/platform/biometrics/biometric-state.service.ts: 30
	Client_Password_In_Comment	/apps/web/src/app/auth/key-rotation/user-key-rotation.service.ts: 42
	Client_Password_In_Comment	/apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 418
	Client_Password_In_Comment	/apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 342
	Client_Password_In_Comment	/apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 342
	Client_Password_In_Comment	/apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 389
	Client_Password_In_Comment	/apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 321
	Client_Password_In_Comment	/apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 321
	Client_Password_In_Comment	/apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 276
	Client_Password_In_Comment	/apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 248
	Client_Password_In_Comment	/apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 439
	Client_Password_In_Comment	/apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 457
	Client_Password_In_Comment	/apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 226
	Client_Password_In_Comment	/apps/browser/src/autofill/background/overlay.background.ts: 516
	Client_Password_In_Comment	/apps/browser/src/autofill/background/overlay.background.ts: 516
	Client_Password_In_Comment	/apps/browser/src/autofill/background/overlay.background.ts: 227
	Client_Password_In_Comment	/apps/browser/src/autofill/background/overlay.background.ts: 227

More results are available on AST platform

KiruthigaManivannan added 3 commits March 29, 2024 20:15

PM-2048 Migrate Two factor options component

d3f4d0e

Merge branch 'main' of https://github.com/bitwarden/clients into PM-2…

077d02b

…048-update-two-factor-options-dialog

PM-2048 Update Two Factor Options Dialog

a3d0333

KiruthigaManivannan requested a review from a team as a code owner April 1, 2024 12:43

KiruthigaManivannan requested a review from ike-kottlowski April 1, 2024 12:43

github-actions bot added the needs-qa Marks a PR as requiring QA approval label Apr 1, 2024

KiruthigaManivannan requested a review from willmartian April 1, 2024 12:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PM 2048 Update Two Factor Options dialog #8565

PM 2048 Update Two Factor Options dialog #8565

KiruthigaManivannan commented Apr 1, 2024 •

edited

codecov bot commented Apr 1, 2024

github-actions bot commented Apr 1, 2024

PM 2048 Update Two Factor Options dialog #8565

Are you sure you want to change the base?

PM 2048 Update Two Factor Options dialog #8565

Conversation

KiruthigaManivannan commented Apr 1, 2024 • edited

Type of change

Objective

Code changes

Screenshots

codecov bot commented Apr 1, 2024

Codecov Report

github-actions bot commented Apr 1, 2024

New Issues

Fixed Issues

KiruthigaManivannan commented Apr 1, 2024 •

edited