CEF #8575
Draft
CEF #8575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created types for the Credential Exchange Format Created test-data Created cef-importer Wrote unit tests that cover importing: - basic-auth logins - partial passkey support - credit-cards - folders and subfolders - collections and subcollections when importing into an organization
…rt, which will call the proper CEFImporter Will fail because of incomplete passkey support Comment out the passkey part in the example file to test complete flow.
…the import-browser component
|
New Issues
|
…t-script-poc # Conflicts: # package-lock.json
Hinton
commented
Apr 9, 2024
| @@ -289,7 +289,7 @@ export class Fido2AuthenticatorService implements Fido2AuthenticatorServiceAbstr | |||
| return { | |||
| authenticatorData, | |||
| selectedCredential: { | |||
| id: guidToRawFormat(selectedCredentialId), | |||
| id: Utils.fromUtf8ToArray(selectedCredentialId), | |||
There was a problem hiding this comment.
@coroiu This seems to be the main difference in how we handle passkeys. I think we can essentially migrate to storing our data B64Url encoded directly and have a if UUID fallback pattern.
There was a problem hiding this comment.
Yeah looks good, we should've done this from the start, but alas, we have debt instead :)
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Code changes
Screenshots
Before you submit