-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AC-2420] Hide SM checkbox on member invite when org is on SM Standalone #8644
[AC-2420] Hide SM checkbox on member invite when org is on SM Standalone #8644
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8644 +/- ##
==========================================
- Coverage 27.32% 27.31% -0.01%
==========================================
Files 2349 2349
Lines 68613 68632 +19
Branches 12828 12831 +3
==========================================
Hits 18748 18748
- Misses 48455 48474 +19
Partials 1410 1410 ☔ View full report in Codecov by Sentry. |
No New Or Fixed Issues Found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
8863554
@cturnbull-bitwarden @r-tome Can I get another look at this when you both have a sec? I had to change it from hiding the SM checkbox to defaulting it to checked and disabling it as shown below: |
fce0beb
…one (#8644) * Refactoring * Hide SM toggle on member invite and default to true for SM standalone org * changed from hide sm checkbox to default and disable * Removed errant addition from conflict resolution
Type of change
Objective
This PR updates the
people.component
to check if the current organization is on SM Standalone. If it is, when the user tries to invite a new member, it hides the option to give the invited member access to SM and defaults it totrue
. This enforces a rule that SM standalone orgs cannot invite PM only members.Code changes
accessSecretsManager
totrue
when org is on SM standalone.Unrelated Refactoring
Screenshots
Screen.Recording.2024-04-08.at.2.51.23.PM.mov
Before you submit