Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM 5025] migrate update license component #8652

Merged
merged 5 commits into from
May 21, 2024

Conversation

vinith-kovan
Copy link
Collaborator

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [X] Other

Objective

Migrate the Update license component to use the component library.

Code changes

update-license.component.html: Updated the form, and inputs to use the equivalent components from the Component Library.
update-license.component.ts: Added from group to capture the form values

Screenshots

update.license.mp4

@vinith-kovan vinith-kovan requested a review from a team as a code owner April 9, 2024 11:04
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Apr 9, 2024
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 3.84615% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 28.12%. Comparing base (acb1535) to head (9b5ec53).

Files Patch % Lines
...src/app/billing/shared/update-license.component.ts 3.84% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8652      +/-   ##
==========================================
- Coverage   28.12%   28.12%   -0.01%     
==========================================
  Files        2362     2362              
  Lines       69880    69888       +8     
  Branches    13141    13143       +2     
==========================================
  Hits        19654    19654              
- Misses      48668    48676       +8     
  Partials     1558     1558              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Apr 9, 2024

Logo
Checkmarx One – Scan Summary & Details63acb4be-4028-4038-b812-6afa26aad1bc

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Missing_HSTS_Header /libs/common/src/services/api.service.ts: 222 Attack Vector

Copy link
Contributor

@cyprain-okeke cyprain-okeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinith-kovan vinith-kovan merged commit cdf93df into main May 21, 2024
28 of 29 checks passed
@vinith-kovan vinith-kovan deleted the PM-5025-Migrate-update-license-component branch May 21, 2024 18:32
quexten pushed a commit that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants