[PM 4983] migrate vault timeout input component #8661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8661 +/- ##
==========================================
- Coverage 28.15% 27.20% -0.96%
==========================================
Files 2369 2339 -30
Lines 70028 68267 -1761
Branches 13160 12749 -411
==========================================
- Hits 19718 18570 -1148
+ Misses 48751 48301 -450
+ Partials 1559 1396 -163 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
vinith-kovan
force-pushed
the
PM-4983-Migrate-vault-timeout-input-component
branch
from
8dd4a7a
to
a4baa6b
Compare
vincentsalucci
requested review from
eliykat
and removed request for
vincentsalucci
eliykat
requested review from
a team and
ike-kottlowski
and removed request for
a team and
eliykat
|
I've requested a review from Auth Team as they should be code owners and they're also the team listed on the Jira ticket. |
ike-kottlowski
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Migrate the Vault timeout input component to use the component library.
Code changes
vault-timeout-input.component.html - Updated the inputs, and select options to use the equivalent components from the Component Library.
Screenshots
preference.mp4