[PM-7413] fix(8560): refreshing reports pages displays empty pages

[abarghoud]

Type of change

- [X] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Resolved #8560, ciphers data are lost when refreshing reports pages

Code changes

• cipher-report.component.ts: Adds a call to syncService.fullSync(false) in the load() method
• admin-console/organizations/tools/*-report.component.ts: addition of syncService dependency
• tools/reports/pages/*-report.component.ts: addition of syncService dependency
• *.spec.ts: addition of a test to make sure syncService.fullSync(false) is called

Before you submit

• Please add unit tests where it makes sense to do so (encouraged but not required)
• If this change requires a documentation update - notify the documentation team
• If this change has particular deployment requirements - notify the DevOps team
• Ensure that all UI additions follow WCAG AA requirements

[bitwarden-bot]

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-7413

[abarghoud]

I fixed it this way, but I think it could be resolved differently with resolvers, defined at the routes level, which blocks access to the page till all necessary data is fetched; I did not see it implemented elsewhere in the repo.

[eliykat]

The main operational change here is to cipher-report.component.ts which is owned by @bitwarden/team-tools-dev so I'll defer to them on the review. If that is approved then the AC Team changes are uncontroversial.

[aj-rosado]

Thank you for your contribution @abarghoud !

This change seems to fix the issue, I'm passing it to QA testing.

[aj-rosado]

@abarghoud there are some changes on the reports files that are conflicting with the changes on this PR.
Can you merge this branch with the most recent version from main and resolve the conflicts please?

If you can't, could you give me permission to push into your repository so that I can fix them?

thank you!

[abarghoud]

@abarghoud there are some changes on the reports files that are conflicting with the changes on this PR. Can you merge this branch with the most recent version from main and resolve the conflicts please?

If you can't, could you give me permission to push into your repository so that I can fix them?

thank you!

@aj-rosado Done ;)

[aj-rosado]

Thank you for your contribution @abarghoud ! QA has approved it and has been merged into main!

This will be part of the next release ! 🎉