-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-7029] Remove key-rotation-feature-flag #8816
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8816 +/- ##
==========================================
- Coverage 27.76% 27.75% -0.01%
==========================================
Files 2419 2419
Lines 70042 70024 -18
Branches 13046 13042 -4
==========================================
- Hits 19444 19435 -9
+ Misses 49085 49077 -8
+ Partials 1513 1512 -1 ☔ View full report in Codecov by Sentry. |
No New Or Fixed Issues Found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed AC owned file 👍
Type of change
Objective
Removed the
key-rotation-feature-flag
from clients code.This was causing #8453 for self-hosted customers with the flag off. Rather than try to fix the issue, I elected to remove the flag as the feature has already been enabled.
See corresponding server PR: bitwarden/server#4002
Before you submit