Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate login strategy deps #8859

Merged
merged 3 commits into from
May 21, 2024

Conversation

jlf0dev
Copy link
Member

@jlf0dev jlf0dev commented Apr 22, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Adding any dependencies to the base login strategy can be difficult since you must pass it through every child login strategy. This change hides the base login strategy dependencies from the children, making it easier to alter or add new ones.

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@jlf0dev jlf0dev requested a review from a team as a code owner April 22, 2024 15:21
@jlf0dev jlf0dev requested a review from rr-bw April 22, 2024 15:21
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Apr 22, 2024
@jlf0dev jlf0dev removed the needs-qa Marks a PR as requiring QA approval label Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 28.03%. Comparing base (6fd81fa) to head (661e076).

Files Patch % Lines
...ervices/login-strategies/login-strategy.service.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8859   +/-   ##
=======================================
  Coverage   28.02%   28.03%           
=======================================
  Files        2360     2360           
  Lines       69779    69777    -2     
  Branches    13125    13125           
=======================================
+ Hits        19557    19563    +6     
+ Misses      48674    48666    -8     
  Partials     1548     1548           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅 🚀

What a fantastic QOL improvement. Thank you for doing this!

Copy link
Contributor

github-actions bot commented Apr 22, 2024

Logo
Checkmarx One – Scan Summary & Details09ea17a2-e157-418a-a731-c2a770b29542

No New Or Fixed Issues Found

@rr-bw rr-bw removed their request for review May 17, 2024 16:43
@jlf0dev jlf0dev merged commit 56c4be4 into main May 21, 2024
61 of 62 checks passed
@jlf0dev jlf0dev deleted the auth/BEEEP/consolidate-login-strategies-deps branch May 21, 2024 13:34
quexten pushed a commit that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants