-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate login strategy deps #8859
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8859 +/- ##
=======================================
Coverage 28.02% 28.03%
=======================================
Files 2360 2360
Lines 69779 69777 -2
Branches 13125 13125
=======================================
+ Hits 19557 19563 +6
+ Misses 48674 48666 -8
Partials 1548 1548 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏅 🚀
What a fantastic QOL improvement. Thank you for doing this!
No New Or Fixed Issues Found |
Type of change
Objective
Adding any dependencies to the base login strategy can be difficult since you must pass it through every child login strategy. This change hides the base login strategy dependencies from the children, making it easier to alter or add new ones.
Code changes
Screenshots
Before you submit