Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-2406] migrate activate autofill component #8883

Merged
merged 8 commits into from
May 21, 2024

Conversation

vinith-kovan
Copy link
Collaborator

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [X] Other

Objective

Migrate the activate-autofill component to use the component library.

Code changes

activate-autofill.component.html - Updated the bootstrap css to use the equivalent components from the Component Library.

Screenshots

autofill.-.Made.with.Clipchamp.mp4

@vinith-kovan vinith-kovan requested a review from a team as a code owner April 23, 2024 18:04
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Apr 23, 2024
Copy link
Contributor

github-actions bot commented Apr 23, 2024

Logo
Checkmarx One – Scan Summary & Details3661d442-0e54-4581-bbfc-bacbd628a8d9

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Missing_HSTS_Header /libs/common/src/services/api.service.ts: 222 Attack Vector

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.13%. Comparing base (cdf93df) to head (51614a1).
Report is 1 commits behind head on main.

Current head 51614a1 differs from pull request most recent head 3fd7c4b

Please upload reports for the commit 3fd7c4b to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8883      +/-   ##
==========================================
+ Coverage   28.12%   28.13%   +0.01%     
==========================================
  Files        2362     2361       -1     
  Lines       69888    69826      -62     
  Branches    13143    13131      -12     
==========================================
- Hits        19654    19644      -10     
+ Misses      48676    48626      -50     
+ Partials     1558     1556       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincentsalucci vincentsalucci removed the needs-qa Marks a PR as requiring QA approval label May 16, 2024
@vinith-kovan vinith-kovan merged commit 239c064 into main May 21, 2024
17 checks passed
@vinith-kovan vinith-kovan deleted the AC-2406-Migrate-activate-autofill-component branch May 21, 2024 18:51
quexten pushed a commit that referenced this pull request May 22, 2024
* migrating activate autofill component

* migrating activate autofill component

* migrating activate autofill component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants