Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-2400] migrating accept families for enterprise setup component #8895

Merged

Conversation

vinith-kovan
Copy link
Collaborator

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [X] Other

Objective

Migrate the accept families for enterprise setup component to use the component library.

Code changes

families-for-enterprise-setup.component.html - Updated the bootstrap css to use the equivalent components from the Component Library.
families-for-enterprise-setup.component.ts - Added the Form group to capture the input values.

Screenshots

Families.-.Made.with.Clipchamp.mp4

@vinith-kovan vinith-kovan requested a review from a team as a code owner April 24, 2024 08:12
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 28.14%. Comparing base (82a83ea) to head (845d57c).

Files Patch % Lines
...orships/families-for-enterprise-setup.component.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8895      +/-   ##
==========================================
- Coverage   28.15%   28.14%   -0.01%     
==========================================
  Files        2369     2369              
  Lines       70045    70049       +4     
  Branches    13161    13162       +1     
==========================================
  Hits        19718    19718              
- Misses      48768    48772       +4     
  Partials     1559     1559              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Apr 24, 2024

Logo
Checkmarx One – Scan Summary & Details5485242b-df83-40ad-a910-f3ce6b6113d9

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Angular_Improper_Type_Pipe_Usage /apps/browser/src/vault/popup/components/vault/vault-v2.component.html: 37 Attack Vector
MEDIUM Angular_Improper_Type_Pipe_Usage /apps/browser/src/vault/popup/components/vault/vault-v2.component.html: 27 Attack Vector
MEDIUM Angular_Improper_Type_Pipe_Usage /apps/browser/src/vault/popup/components/vault/vault-v2.component.html: 24 Attack Vector
MEDIUM Angular_Improper_Type_Pipe_Usage /apps/browser/src/vault/popup/components/vault/vault-v2.component.html: 14 Attack Vector

@vinith-kovan vinith-kovan changed the title [AC-2399] migrating accept families for enterprise setup component [AC-2400] migrating accept families for enterprise setup component Apr 25, 2024
@vinith-kovan vinith-kovan merged commit b672b03 into main May 22, 2024
33 of 34 checks passed
@vinith-kovan vinith-kovan deleted the AC-2399-Migrate-accept-family-sponsorship-component branch May 22, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants