Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SM-1192] displaying full project name in tooltip and allowing more of project name in bit badge/project column #8917

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

cd-bitwarden
Copy link
Contributor

Allowing max width adjustment on bit badge and not truncating the tooltip

Type of change

- [ x ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Allowing max width adjustment on bit badge and not truncating the tooltip so the user can see more of the project name easily when viewing the secrets list.

Code changes

Updated the bit badge directive file to allow customizing the max width, removing truncation pipe from the project name on the secrets list.

  • file.ext: Description of what was changed and why

Screenshots

Updated UI
image

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@cd-bitwarden cd-bitwarden requested review from a team as code owners April 25, 2024 14:59
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Apr 25, 2024
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 27.73%. Comparing base (b4631b0) to head (a55e577).

Files Patch % Lines
libs/components/src/badge/badge.directive.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8917      +/-   ##
==========================================
- Coverage   27.73%   27.73%   -0.01%     
==========================================
  Files        2405     2405              
  Lines       69596    69597       +1     
  Branches    12954    12954              
==========================================
  Hits        19302    19302              
- Misses      48806    48807       +1     
  Partials     1488     1488              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Apr 25, 2024

Logo
Checkmarx One – Scan Summary & Details3e7740f5-45b6-48ec-8eed-ffdf86d872cc

No New Or Fixed Issues Found

Thomas-Avery
Thomas-Avery previously approved these changes Apr 26, 2024
Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from the SM perspective.

Let's make sure the component library team is good with the proposed change.

Copy link
Contributor

@willmartian willmartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cd-bitwarden! Looks good, tiny change request:

@@ -65,6 +65,8 @@ export class BadgeDirective implements FocusableElement {
*/
@Input() truncate = true;

@Input() maxWidth = "tw-max-w-40";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the type to be more restrictive? And the name to convey that we expect a Tailwind class instead of a raw value.

  @Input() maxWidthClass: `tw-max-w-${string}` = "tw-max-w-40";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants