New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SM-1192] displaying full project name in tooltip and allowing more of project name in bit badge/project column #8917
base: main
Are you sure you want to change the base?
Conversation
…ltip text on project
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8917 +/- ##
==========================================
- Coverage 27.73% 27.73% -0.01%
==========================================
Files 2405 2405
Lines 69596 69597 +1
Branches 12954 12954
==========================================
Hits 19302 19302
- Misses 48806 48807 +1
Partials 1488 1488 ☔ View full report in Codecov by Sentry. |
No New Or Fixed Issues Found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from the SM perspective.
Let's make sure the component library team is good with the proposed change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @cd-bitwarden! Looks good, tiny change request:
@@ -65,6 +65,8 @@ export class BadgeDirective implements FocusableElement { | |||
*/ | |||
@Input() truncate = true; | |||
|
|||
@Input() maxWidth = "tw-max-w-40"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the type to be more restrictive? And the name to convey that we expect a Tailwind class instead of a raw value.
@Input() maxWidthClass: `tw-max-w-${string}` = "tw-max-w-40";
Allowing max width adjustment on bit badge and not truncating the tooltip
Type of change
Objective
Allowing max width adjustment on bit badge and not truncating the tooltip so the user can see more of the project name easily when viewing the secrets list.
Code changes
Updated the bit badge directive file to allow customizing the max width, removing truncation pipe from the project name on the secrets list.
Screenshots
Updated UI
Before you submit