Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7750] add error handling to runtime.background messaging #8949

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

jlf0dev
Copy link
Member

@jlf0dev jlf0dev commented Apr 27, 2024

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

adds error handling to our background messages.

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Apr 27, 2024
Copy link

codecov bot commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 27.75%. Comparing base (6ae086f) to head (cbf8068).

Files Patch % Lines
apps/browser/src/background/runtime.background.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8949      +/-   ##
==========================================
- Coverage   27.75%   27.75%   -0.01%     
==========================================
  Files        2392     2392              
  Lines       69338    69340       +2     
  Branches    12932    12932              
==========================================
  Hits        19243    19243              
- Misses      48646    48648       +2     
  Partials     1449     1449              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlf0dev jlf0dev merged commit 3282b9b into main Apr 27, 2024
24 of 25 checks passed
@jlf0dev jlf0dev deleted the auth/pm-7750-part-2 branch April 27, 2024 14:51
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsc86842ce-8a58-4e73-978b-11ff7e37afca

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants