[PM-7777] Enhanced password generation

[karma993892]

• Added new option to add extra special characters

Type of change

- [ ] Bug fix
- [X] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Added 19 additional special characters (()[]{}?/\-_.:,;=+<>), which can be activated/deactivated without affecting the existing ones. The reason for putting a separate switch is because some web pages may not support certain characters or the user may not want such a complex password.

Code changes

• apps/browser/src/tools/popup/generator/generator.component.html: Added an appBoxRow to enable/disable the extra special characters.
• libs/common/src/tools/generator/password/password-generation-options.ts: Added boolean (false by default) for extra special characters
• libs/common/src/tools/generator/password/password-generation.service.ts: Added logic to concatenate the extra special characters as required.

Screenshots

Disabled

Enabled

Deployment requirements

If this pull request is accepted, the name of the appBoxRow is written directly in the .html in English and a key would have to be assigned for its translation (I mention it here because I don't know if I should have done it myself, but after a while researching about the translation system and messing around on https://crowdin.com/project/bitwarden-browser, I haven't been able to do this myself).

[bitwarden-bot]

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-7777

[holow29]

Seems like it might be better to put this as an option below !@#$%^&* as ()[]{}?/\-_.:,;=+<>

[karma993892]

Seems like it might be better to put this as an option below !@#$%^&* as ()[]{}?/\-_.:,;=+<>

I was hesitating between both options and in the end I opted for the one I have published, because I think it may be less confusing for an ordinary user, since in the way you indicate, the special characters !@#$%^&* would have to be activated when only the option ()[]{}?/\-_.:,;=+<> is activated, or vice versa, if both options are activated and !@#$%^&* is unchecked, ()[]{}?/\-_.:,;=+<> would also have to be unchecked, otherwise the user would understand that the password should be generated with ()[]{}?/\-_.:,;=+<> without the need to activate !@#$%^&*. The way I have posted it, I think it is clearer that ()[]{}?/\-_.:,;=+<> will only be added if !@#$%^&* is enabled. (I don't know if I've made myself clear 😅)

[audrey-jensen]

Hi @karma993892!

Thank you for your interest in expanding the flexibility of the password generator. We're interested in expanding the character set, too!

We're presently in the middle of a significant refactoring that invalidates the logic you've edited, unfortunately. We're not able to accept PRs for it at this time.