[PM-2057] update two factor email dialog #8974
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…057-Update-two-factor-email-dialog
|
No New Or Fixed Issues Found |
jlf0dev
approved these changes
May 8, 2024
jlf0dev
requested changes
May 9, 2024
| </button> | ||
| <button type="button" class="btn btn-outline-secondary" data-dismiss="modal"> | ||
| {{ "close" | i18n }} | ||
| <form [formGroup]="formGroup" [bitSubmit]="submit" [appApiAction]="formPromise" *ngIf="authed"> |
There was a problem hiding this comment.
We can remove the appApiAction and formPromise from this component
…057-Update-two-factor-email-dialog
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8974 +/- ##
==========================================
- Coverage 28.06% 28.05% -0.02%
==========================================
Files 2391 2391
Lines 70512 70531 +19
Branches 13205 13208 +3
==========================================
- Hits 19789 19785 -4
- Misses 49158 49178 +20
- Partials 1565 1568 +3 ☔ View full report in Codecov by Sentry. |
…057-Update-two-factor-email-dialog
…057-Update-two-factor-email-dialog
jlf0dev
requested changes
May 22, 2024
| const authComp: DialogRef<boolean, any> = TwoFactorEmailComponent.open(this.dialogService, { | ||
| data: result, | ||
| }); | ||
| authComp.componentInstance.onChangeStatus.subscribe((enabled: boolean) => { |
There was a problem hiding this comment.
This needs to have a takeUntil that will clean up the subscription when the authComp.closed observable emits.
…057-Update-two-factor-email-dialog
jlf0dev
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Update Two Factor email component to use the component library.
Code changes
two-factor-email.component.html - Updated the bootstrap CSS to use the equivalent components from the Component Library.
two-factor-email.component.ts - Updated the dialog service from modal.
two-factor-setup.component.ts - Updated the email switch case to call the two-factor email dialog service.
Screenshots
t0w-factor-email.-.Made.with.Clipchamp.mp4