-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AC-2554] Prevent calls to billing-status endpoint when feature flag is off #9032
[AC-2554] Prevent calls to billing-status endpoint when feature flag is off #9032
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9032 +/- ##
==========================================
- Coverage 27.75% 27.73% -0.03%
==========================================
Files 2420 2418 -2
Lines 70063 69952 -111
Branches 13047 12987 -60
==========================================
- Hits 19444 19399 -45
+ Misses 49106 49054 -52
+ Partials 1513 1499 -14 ☔ View full report in Codecov by Sentry. |
No New Or Fixed Issues Found |
Hey @MGibson1, apologies - had to resolve a merge conflict. Can I get another stamp here when possible? |
(cherry picked from commit 59c9606)
(cherry picked from commit 59c9606)
Type of change
Objective
As a relic of the Payment Method Warning Banners that are currently off behind a feature flag, there’s a timer in the web application that tries to make a request to the Billing Status endpoint in server and use the result to update the state. These timed calls should also be gated behind the same feature flag so we don’t clutter our network requests.
Code changes