Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-1938 Migrate Accept Emergency Component #9177

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

KiruthigaManivannan
Copy link
Collaborator

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [x] Other

Objective

Migrate the Accept Emergency Component to use the component library.

Code changes

  • accept-emergency.component.html: Added buttons from library
  • oss-routing.module.ts: Added Routing for Anon layout wrapper component.

Screenshots

Emergency.access._.Bitwarden.Web.vault.-.Google.Chrome.2024-05-14.20-54-08.mp4

@KiruthigaManivannan KiruthigaManivannan requested a review from a team as a code owner May 14, 2024 15:35
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 28.13%. Comparing base (13c2c2e) to head (8d84b4b).

Files Patch % Lines
apps/web/src/app/oss-routing.module.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9177   +/-   ##
=======================================
  Coverage   28.12%   28.13%           
=======================================
  Files        2426     2426           
  Lines       71401    71403    +2     
  Branches    13325    13325           
=======================================
+ Hits        20084    20091    +7     
+ Misses      49739    49734    -5     
  Partials     1578     1578           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 14, 2024

Logo
Checkmarx One – Scan Summary & Details78789d4f-7f44-4526-ba6b-794df062215b

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Client_Privacy_Violation /apps/web/src/app/auth/recover-two-factor.component.html: [37](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/app/auth/recover-two-factor.component.html# L37) Attack Vector

Fixed Issues

Severity Issue Source File / Package
HIGH Client_DOM_Code_Injection /apps/web/src/connectors/common.ts: [2](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/connectors/common.ts# L2)
HIGH Client_DOM_Code_Injection /apps/browser/src/autofill/services/collect-autofill-content.service.ts: [1071](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/autofill/services/collect-autofill-content.service.ts# L1071)
HIGH Client_DOM_Stored_XSS /apps/web/src/connectors/sso.ts: [33](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/connectors/sso.ts# L33)
HIGH Client_DOM_XSS /apps/browser/src/auth/scripts/duo.js: [285](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/auth/scripts/duo.js# L285)
HIGH Client_DOM_XSS /apps/browser/src/auth/scripts/duo.js: [285](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/auth/scripts/duo.js# L285)
HIGH Client_DOM_XSS /apps/desktop/src/auth/scripts/duo.js: [285](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/desktop/src/auth/scripts/duo.js# L285)
HIGH Client_DOM_XSS /apps/desktop/src/auth/scripts/duo.js: [285](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/desktop/src/auth/scripts/duo.js# L285)
HIGH Client_DOM_XSS /apps/web/src/connectors/common.ts: [2](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/connectors/common.ts# L2)
HIGH Client_DOM_XSS /apps/web/src/connectors/common.ts: [2](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/connectors/common.ts# L2)
HIGH Client_DOM_XSS /apps/web/src/connectors/common.ts: [2](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/connectors/common.ts# L2)
HIGH Client_DOM_XSS /apps/web/src/connectors/common.ts: [2](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/connectors/common.ts# L2)
HIGH Client_DOM_XSS /apps/web/src/connectors/sso.ts: [21](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/connectors/sso.ts# L21)
HIGH Client_DOM_XSS /apps/web/src/connectors/sso.ts: [19](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/connectors/sso.ts# L19)
HIGH Client_DOM_XSS /apps/web/src/connectors/sso.ts: [15](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/connectors/sso.ts# L15)
MEDIUM Absolute_Path_Traversal /apps/cli/src/commands/serve.command.ts: [315](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/cli/src/commands/serve.command.ts# L315)
MEDIUM Absolute_Path_Traversal /apps/cli/src/commands/serve.command.ts: [315](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/cli/src/commands/serve.command.ts# L315)
MEDIUM Absolute_Path_Traversal /apps/cli/src/commands/serve.command.ts: [347](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/cli/src/commands/serve.command.ts# L347)
MEDIUM Absolute_Path_Traversal /apps/cli/src/commands/serve.command.ts: [347](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/cli/src/commands/serve.command.ts# L347)
MEDIUM Angular_Improper_Type_Pipe_Usage /apps/browser/src/vault/popup/components/fido2/fido2-use-browser-link.component.html: [1](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/vault/popup/components/fido2/fido2-use-browser-link.component.html# L1)
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/password-generator-history.component.html: [11](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/app/tools/password-generator-history.component.html# L11)
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/password-generator-history.component.html: [11](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/app/tools/password-generator-history.component.html# L11)
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/password-generator-history.component.html: [11](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/app/tools/password-generator-history.component.html# L11)
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/password-generator-history.component.html: [11](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/app/tools/password-generator-history.component.html# L11)
MEDIUM Client_Privacy_Violation /apps/web/src/app/auth/recover-two-factor.component.ts: [18](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/app/auth/recover-two-factor.component.ts# L18)
MEDIUM Client_Privacy_Violation /apps/browser/src/background/runtime.background.ts: [323](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/background/runtime.background.ts# L323)
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/reports/pages/breach-report.component.html: [14](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/app/tools/reports/pages/breach-report.component.html# L14)
MEDIUM Client_Privacy_Violation /apps/browser/src/auth/popup/account-switching/account.component.ts: [12](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/auth/popup/account-switching/account.component.ts# L12)
MEDIUM Client_Privacy_Violation /apps/browser/src/auth/popup/account-switching/account.component.ts: [12](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/auth/popup/account-switching/account.component.ts# L12)
MEDIUM Client_Privacy_Violation /apps/browser/src/auth/popup/account-switching/account.component.ts: [12](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/auth/popup/account-switching/account.component.ts# L12)
MEDIUM Client_Privacy_Violation /libs/components/src/color-password/color-password.component.ts: [26](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//libs/components/src/color-password/color-password.component.ts# L26)
MEDIUM Client_Privacy_Violation /apps/desktop/src/auth/lock.component.html: [32](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/desktop/src/auth/lock.component.html# L32)
MEDIUM Client_Privacy_Violation /apps/web/src/app/auth/lock.component.html: [18](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/app/auth/lock.component.html# L18)
MEDIUM Client_Privacy_Violation /bitwarden_license/bit-web/src/app/auth/sso/sso.component.ts: [161](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//bitwarden_license/bit-web/src/app/auth/sso/sso.component.ts# L161)
MEDIUM Client_Privacy_Violation /apps/web/src/app/auth/lock.component.html: [18](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/app/auth/lock.component.html# L18)
MEDIUM Client_Privacy_Violation /apps/desktop/src/auth/lock.component.html: [32](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/desktop/src/auth/lock.component.html# L32)
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: [534](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/desktop/src/vault/app/vault/view.component.html# L534)
MEDIUM Client_Privacy_Violation /apps/web/src/connectors/webauthn-fallback.ts: [116](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/connectors/webauthn-fallback.ts# L116)
MEDIUM Client_Privacy_Violation /bitwarden_license/bit-web/src/app/auth/sso/sso.component.ts: [161](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//bitwarden_license/bit-web/src/app/auth/sso/sso.component.ts# L161)
MEDIUM Client_Privacy_Violation /libs/components/src/color-password/color-password.component.ts: [14](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//libs/components/src/color-password/color-password.component.ts# L14)
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: [60](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/desktop/src/vault/app/vault/view.component.html# L60)
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: [56](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/desktop/src/vault/app/vault/view.component.html# L56)
MEDIUM Client_Privacy_Violation /apps/browser/src/tools/popup/generator/password-generator-history.component.html: [26](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/tools/popup/generator/password-generator-history.component.html# L26)
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/password-history.component.html: [18](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/vault/popup/components/vault/password-history.component.html# L18)
MEDIUM Client_Privacy_Violation /apps/desktop/src/app/tools/password-generator-history.component.html: [15](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/desktop/src/app/tools/password-generator-history.component.html# L15)
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/password-history.component.html: [12](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/desktop/src/vault/app/vault/password-history.component.html# L12)
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: [50](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/desktop/src/vault/app/vault/view.component.html# L50)
MEDIUM Client_Privacy_Violation /libs/components/src/color-password/color-password.component.ts: [14](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//libs/components/src/color-password/color-password.component.ts# L14)
MEDIUM Client_Privacy_Violation /apps/browser/src/tools/popup/generator/password-generator-history.component.html: [26](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/tools/popup/generator/password-generator-history.component.html# L26)
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/vault/password-history.component.html: [18](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/vault/popup/components/vault/password-history.component.html# L18)
MEDIUM Client_Privacy_Violation /apps/desktop/src/app/tools/password-generator-history.component.html: [15](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/desktop/src/app/tools/password-generator-history.component.html# L15)
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/password-history.component.html: [12](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/desktop/src/vault/app/vault/password-history.component.html# L12)
MEDIUM Missing_HSTS_Header /apps/cli/src/auth/commands/login.command.ts: [707](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/cli/src/auth/commands/login.command.ts# L707)
MEDIUM SSRF /libs/importer/src/importers/lastpass/access/services/rest-client.ts: [69](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//libs/importer/src/importers/lastpass/access/services/rest-client.ts# L69)
MEDIUM SSRF /libs/importer/src/importers/lastpass/access/services/rest-client.ts: [69](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//libs/importer/src/importers/lastpass/access/services/rest-client.ts# L69)
LOW Angular_Usage_of_Unsafe_DOM_Sanitizer /apps/desktop/src/app/components/avatar.component.ts: [75](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/desktop/src/app/components/avatar.component.ts# L75)
LOW Angular_Usage_of_Unsafe_DOM_Sanitizer /libs/components/src/avatar/avatar.component.ts: [80](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//libs/components/src/avatar/avatar.component.ts# L80)
LOW Angular_Usage_of_Unsafe_DOM_Sanitizer /libs/components/src/icon/icon.component.ts: [18](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//libs/components/src/icon/icon.component.ts# L18)
LOW Angular_Usage_of_Unsafe_DOM_Sanitizer /libs/components/src/icon/icon.component.ts: [18](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//libs/components/src/icon/icon.component.ts# L18)
LOW Client_DOM_Open_Redirect /apps/browser/src/platform/popup/layout/popup-header.component.ts: [29](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/platform/popup/layout/popup-header.component.ts# L29)
LOW Client_DOM_Open_Redirect /apps/desktop/src/auth/accessibility-cookie.component.html: [18](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/desktop/src/auth/accessibility-cookie.component.html# L18)
LOW Client_DOM_Open_Redirect /apps/web/src/connectors/common.ts: [2](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/connectors/common.ts# L2)
LOW Client_DOM_Open_Redirect /apps/web/src/connectors/common.ts: [2](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/connectors/common.ts# L2)
LOW Client_DOM_Open_Redirect /apps/web/src/connectors/common.ts: [2](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/connectors/common.ts# L2)
LOW Client_DOM_Open_Redirect /apps/web/src/connectors/sso.ts: [21](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/connectors/sso.ts# L21)
LOW Client_DOM_Open_Redirect /apps/web/src/connectors/common.ts: [2](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/connectors/common.ts# L2)
LOW Client_DOM_Open_Redirect /apps/web/src/connectors/sso.ts: [19](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/connectors/sso.ts# L19)
LOW Client_DOM_Open_Redirect /apps/web/src/connectors/common.ts: [2](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/connectors/common.ts# L2)
LOW Client_DOM_Open_Redirect /apps/web/src/connectors/sso.ts: [15](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/connectors/sso.ts# L15)
LOW Client_DOM_Open_Redirect /apps/browser/src/tools/popup/generator/password-generator-history.component.ts: [18](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/tools/popup/generator/password-generator-history.component.ts# L18)
LOW Client_DOM_Open_Redirect /apps/browser/src/auth/popup/account-switching/current-account.component.ts: [35](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/auth/popup/account-switching/current-account.component.ts# L35)
LOW Client_DOM_Open_Redirect /apps/browser/src/auth/popup/login-via-auth-request.component.ts: [52](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/auth/popup/login-via-auth-request.component.ts# L52)
LOW Client_DOM_Open_Redirect /apps/browser/src/auth/popup/login-via-auth-request.component.ts: [52](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/auth/popup/login-via-auth-request.component.ts# L52)
LOW Client_DOM_Open_Redirect /apps/desktop/src/auth/login/login-via-auth-request.component.ts: [60](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/desktop/src/auth/login/login-via-auth-request.component.ts# L60)
LOW Client_DOM_Open_Redirect /apps/desktop/src/auth/login/login-via-auth-request.component.ts: [60](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/desktop/src/auth/login/login-via-auth-request.component.ts# L60)
LOW Client_DOM_Open_Redirect /apps/browser/src/auth/popup/login-via-auth-request.component.ts: [52](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/auth/popup/login-via-auth-request.component.ts# L52)
LOW Client_DOM_Open_Redirect /apps/browser/src/auth/popup/login-via-auth-request.component.ts: [52](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/auth/popup/login-via-auth-request.component.ts# L52)
LOW Client_DOM_Open_Redirect /apps/desktop/src/auth/login/login-via-auth-request.component.ts: [60](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/desktop/src/auth/login/login-via-auth-request.component.ts# L60)
LOW Client_DOM_Open_Redirect /apps/desktop/src/auth/login/login-via-auth-request.component.ts: [60](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/desktop/src/auth/login/login-via-auth-request.component.ts# L60)
LOW Client_DOM_Open_Redirect /apps/browser/src/auth/popup/account-switching/account.component.ts: [24](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/auth/popup/account-switching/account.component.ts# L24)
LOW Client_DOM_Open_Redirect /apps/browser/src/vault/popup/components/vault/password-history.component.ts: [21](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/vault/popup/components/vault/password-history.component.ts# L21)
LOW Client_DOM_Open_Redirect /apps/browser/src/billing/popup/settings/premium.component.ts: [27](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/billing/popup/settings/premium.component.ts# L27)
LOW Client_DOM_Open_Redirect /apps/browser/src/vault/popup/components/vault/attachments.component.ts: [32](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/vault/popup/components/vault/attachments.component.ts# L32)
LOW Client_DOM_Open_Redirect /libs/common/src/auth/iframe-component.ts: [49](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//libs/common/src/auth/iframe-component.ts# L49)
LOW Client_DOM_Open_Redirect /apps/browser/src/auth/scripts/duo.js: [277](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/auth/scripts/duo.js# L277)
LOW Client_DOM_Open_Redirect /apps/browser/src/auth/scripts/duo.js: [277](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/auth/scripts/duo.js# L277)
LOW Client_DOM_Open_Redirect /apps/desktop/src/auth/scripts/duo.js: [277](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/desktop/src/auth/scripts/duo.js# L277)
LOW Client_DOM_Open_Redirect /apps/desktop/src/auth/scripts/duo.js: [277](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/desktop/src/auth/scripts/duo.js# L277)
LOW Client_DOM_Open_Redirect /libs/common/src/auth/webauthn-iframe.ts: [25](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//libs/common/src/auth/webauthn-iframe.ts# L25)
LOW Client_DOM_Open_Redirect /apps/desktop/src/auth/scripts/duo.js: [277](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/desktop/src/auth/scripts/duo.js# L277)
LOW Client_DOM_Open_Redirect /apps/desktop/src/auth/scripts/duo.js: [277](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/desktop/src/auth/scripts/duo.js# L277)
LOW Client_DOM_Open_Redirect /apps/browser/src/auth/scripts/duo.js: [277](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/auth/scripts/duo.js# L277)
LOW Client_DOM_Open_Redirect /apps/browser/src/auth/scripts/duo.js: [277](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/auth/scripts/duo.js# L277)
LOW Client_DOM_Open_Redirect /apps/desktop/src/auth/scripts/duo.js: [277](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/desktop/src/auth/scripts/duo.js# L277)
LOW Client_DOM_Open_Redirect /apps/desktop/src/auth/scripts/duo.js: [277](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/desktop/src/auth/scripts/duo.js# L277)
LOW Client_DOM_Open_Redirect /apps/browser/src/auth/scripts/duo.js: [277](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/auth/scripts/duo.js# L277)
LOW Client_DOM_Open_Redirect /apps/browser/src/auth/scripts/duo.js: [277](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/auth/scripts/duo.js# L277)
LOW Client_DOM_Open_Redirect /libs/common/src/auth/webauthn-iframe.ts: [25](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//libs/common/src/auth/webauthn-iframe.ts# L25)
LOW Client_DOM_Open_Redirect /apps/desktop/src/auth/scripts/duo.js: [277](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/desktop/src/auth/scripts/duo.js# L277)
LOW Client_DOM_Open_Redirect /apps/desktop/src/auth/scripts/duo.js: [277](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/desktop/src/auth/scripts/duo.js# L277)
LOW Client_DOM_Open_Redirect /apps/browser/src/auth/scripts/duo.js: [277](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/auth/scripts/duo.js# L277)
LOW Client_DOM_Open_Redirect /apps/browser/src/auth/scripts/duo.js: [277](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/auth/scripts/duo.js# L277)
LOW Client_Hardcoded_Domain /libs/common/src/billing/services/payment-processors/stripe.service.ts: [23](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//libs/common/src/billing/services/payment-processors/stripe.service.ts# L23)
LOW Client_Hardcoded_Domain /apps/web/src/app/billing/shared/payment.component.ts: [56](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/app/billing/shared/payment.component.ts# L56)
LOW Client_Hardcoded_Domain /apps/web/src/app/billing/shared/payment.component.ts: [56](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/app/billing/shared/payment.component.ts# L56)
LOW Client_Hardcoded_Domain /apps/web/src/connectors/captcha.ts: [57](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/connectors/captcha.ts# L57)
LOW Client_JQuery_Deprecated_Symbols /apps/cli/src/base-program.ts: [115](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/cli/src/base-program.ts# L115)
LOW Client_JQuery_Deprecated_Symbols /apps/cli/src/auth/commands/login.command.ts: [575](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/cli/src/auth/commands/login.command.ts# L575)
LOW Client_JQuery_Deprecated_Symbols /libs/angular/src/auth/components/update-temp-password.component.ts: [132](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//libs/angular/src/auth/components/update-temp-password.component.ts# L132)
LOW Client_JQuery_Deprecated_Symbols /libs/angular/src/auth/components/change-password.component.ts: [91](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//libs/angular/src/auth/components/change-password.component.ts# L91)
LOW Client_Use_Of_Iframe_Without_Sandbox /apps/browser/src/autofill/content/notification-bar.ts: [868](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/autofill/content/notification-bar.ts# L868)
LOW Client_Use_Of_Iframe_Without_Sandbox /apps/browser/src/autofill/overlay/iframe-content/autofill-overlay-iframe.service.ts: [90](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/browser/src/autofill/overlay/iframe-content/autofill-overlay-iframe.service.ts# L90)
LOW Client_Use_Of_Iframe_Without_Sandbox /apps/web/src/connectors/duo.ts: [8](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/connectors/duo.ts# L8)
LOW Client_Use_Of_Iframe_Without_Sandbox /apps/web/src/connectors/duo.ts: [8](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/connectors/duo.ts# L8)
LOW Client_Weak_Cryptographic_Hash /libs/common/src/platform/services/web-crypto-function.service.ts: [142](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//libs/common/src/platform/services/web-crypto-function.service.ts# L142)
LOW Client_Weak_Cryptographic_Hash /apps/desktop/src/proxy/ipc.ts: [24](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/desktop/src/proxy/ipc.ts# L24)
LOW Missing_CSP_Header /apps/cli/src/auth/commands/login.command.ts: [707](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/cli/src/auth/commands/login.command.ts# L707)
LOW Unprotected_Cookie /apps/web/src/app/auth/two-factor.component.ts: [137](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/app/auth/two-factor.component.ts# L137)
LOW Unprotected_Cookie /apps/web/src/connectors/duo-redirect.ts: [57](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/connectors/duo-redirect.ts# L57)
LOW Unprotected_Cookie /apps/web/src/connectors/duo-redirect.ts: [112](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/connectors/duo-redirect.ts# L112)
LOW Unprotected_Cookie /apps/web/src/connectors/sso.ts: [33](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/connectors/sso.ts# L33)
LOW Unprotected_Cookie /apps/web/src/app/auth/sso.component.ts: [137](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/app/auth/sso.component.ts# L137)
LOW Unsafe_Use_Of_Target_blank /apps/web/src/app/auth/settings/two-factor-recovery.component.ts: [32](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/web/src/app/auth/settings/two-factor-recovery.component.ts# L32)
LOW Use_of_Broken_or_Risky_Cryptographic_Algorithm /apps/cli/src/vault/create.command.ts: [68](https://github.com/bitwarden/clients/blob/PM-1938-migrate-accept-emergency-component//apps/cli/src/vault/create.command.ts# L68)

Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for incorporating the feedback! Looks good to me!

…t-emergency-component + resolved merge conflict in oss-routing.module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants