Ps/pm-8003/handle-dekstop-invalidated-message-encryption #9181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handling of this error is to require the user to retry, so the promise needs to resolve.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9181 +/- ##
==========================================
- Coverage 27.79% 27.79% -0.01%
==========================================
Files 2422 2422
Lines 70262 70264 +2
Branches 13101 13103 +2
==========================================
Hits 19531 19531
- Misses 49211 49213 +2
Partials 1520 1520 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
justindbaur
approved these changes
May 15, 2024
MGibson1
deleted the
ps/pm-8003/handle-dekstop-invalidated-message-encryption
branch
justindbaur
pushed a commit
that referenced
this pull request
May 15, 2024
* Do not initialize symmetric crypto keys with null * Require new message on invalid native message encryption Handling of this error is to require the user to retry, so the promise needs to resolve.
Merged
justindbaur
added a commit
that referenced
this pull request
May 15, 2024
* Do not initialize symmetric crypto keys with null * Require new message on invalid native message encryption Handling of this error is to require the user to retry, so the promise needs to resolve. Co-authored-by: Matt Gibson <mgibson@bitwarden.com>
justindbaur
added a commit
that referenced
this pull request
May 15, 2024
* Do not initialize symmetric crypto keys with null * Require new message on invalid native message encryption Handling of this error is to require the user to retry, so the promise needs to resolve. Co-authored-by: Matt Gibson <mgibson@bitwarden.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling of this error is to require the user to retry, so the promise needs to resolve.
Type of change
Objective
Desktop is capable of providing biometrically locked user keys while it itself is locked. However, process reloads are common in this state and this breaks the shared encryption key for native messaging. This PR implements better handling of this state (
"invalidateEncryption"response) by recognizing this is an end-of-message-chain event and resolving any awaited responses as failures.Before you submit