Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PM-8134: Change b64 to b64url #9193

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Fix PM-8134: Change b64 to b64url #9193

merged 1 commit into from
Jun 1, 2024

Conversation

abergs
Copy link
Member

@abergs abergs commented May 15, 2024

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

https://bitwarden.atlassian.net/browse/PM-8134

We should have used base64url, but accidently used base64

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@abergs abergs requested a review from a team as a code owner May 15, 2024 15:30
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.11%. Comparing base (426bacf) to head (e205d86).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9193      +/-   ##
==========================================
- Coverage   28.12%   28.11%   -0.01%     
==========================================
  Files        2427     2427              
  Lines       70347    70347              
  Branches    13126    13126              
==========================================
- Hits        19788    19781       -7     
- Misses      49032    49039       +7     
  Partials     1527     1527              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details0052b7e8-e26e-4d38-9ffa-d40e58cbb718

No New Or Fixed Issues Found

@trmartin4 trmartin4 merged commit 0d492b4 into main Jun 1, 2024
35 checks passed
@trmartin4 trmartin4 deleted the fix/b64url-webauthn branch June 1, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants