-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-6413] Add http loophole for localhost #9236
Open
coroiu
wants to merge
6
commits into
main
Choose a base branch
from
PM-6413-add-http-loophole-for-localhost
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+79
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9236 +/- ##
==========================================
- Coverage 28.31% 28.31% -0.01%
==========================================
Files 2437 2437
Lines 71654 71656 +2
Branches 13398 13400 +2
==========================================
- Hits 20292 20291 -1
- Misses 49768 49773 +5
+ Partials 1594 1592 -2 ☔ View full report in Codecov by Sentry. |
No New Or Fixed Issues Found |
justindbaur
reviewed
May 21, 2024
libs/common/src/platform/services/fido2/fido2-client.service.spec.ts
Outdated
Show resolved
Hide resolved
justindbaur
previously approved these changes
Jun 7, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6882
Type of change
Objective
Check if hostname is
localhost
and skiphttps
requirement.Before you submit