Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-6413] Add http loophole for localhost #9236

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

coroiu
Copy link
Contributor

@coroiu coroiu commented May 17, 2024

Fixes #6882

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Check if hostname is localhost and skip https requirement.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@coroiu coroiu requested a review from a team as a code owner May 17, 2024 15:41
@coroiu coroiu requested a review from justindbaur May 17, 2024 15:41
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.31%. Comparing base (eef1e51) to head (24d3695).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9236      +/-   ##
==========================================
- Coverage   28.31%   28.31%   -0.01%     
==========================================
  Files        2437     2437              
  Lines       71654    71656       +2     
  Branches    13398    13400       +2     
==========================================
- Hits        20292    20291       -1     
- Misses      49768    49773       +5     
+ Partials     1594     1592       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 17, 2024

Logo
Checkmarx One – Scan Summary & Detailse4e8ca67-2b26-4878-9c34-bac1de592749

No New Or Fixed Issues Found

@coroiu coroiu requested a review from justindbaur June 7, 2024 08:14
justindbaur
justindbaur previously approved these changes Jun 7, 2024
@coroiu coroiu requested a review from a team as a code owner June 10, 2024 13:55
@coroiu coroiu requested review from cagonzalezcs and removed request for gbubemismith and a team June 10, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebAuthN fails on localhost because it expects an HTTPS origin
2 participants