Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AC-1712] Add functionality to approve all device approval requests #9251

Merged
merged 76 commits into from
May 27, 2024
Merged

[AC-1712] Add functionality to approve all device approval requests #9251

merged 76 commits into from
May 27, 2024

Conversation

r-tome
Copy link
Contributor

@r-tome r-tome commented May 19, 2024

Type of change

- [ ] Bug fix
- [X] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Add option to bulk approve all pending device approval requests.

Code changes

  • apps/web/src/locales/en/messages.json: Add copy for new option and success toast
  • bitwarden_license/bit-web/src/app/admin-console/organizations/manage/device-approvals/device-approvals.component.html: Add new approve all option
  • bitwarden_license/bit-web/src/app/admin-console/organizations/manage/device-approvals/device-approvals.component.ts: Make API call to approve all requests

Screenshots

image

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

r-tome and others added 30 commits April 17, 2024 13:03
@r-tome
[AC-2302] Move organization-auth-request.service to bit-common folder
eb42a47
@r-tome
[AC-2302] Rename organization-auth-request.service to organization-au…
4e23ab4 
…th-request-api.service
@r-tome
[AC-2302] Move logic from component to organization-auth-request.service
32ac0c8
@r-tome
Merge branch 'main' into ac/ac-2302/move-device-approve-deny-into-a-s…
b9b5972 
…ervice
@r-tome
[AC-2302] Fix import path in OrganizationAuthRequestService
3b860eb
@r-tome
[AC-2302] Move imports to OrganizationsModule and delete unused CoreO…
ce7b253 
…rganizationModule
@r-tome
[AC-2302] Move the call to get userResetPasswordDetails into Organiza…
6f850f9 
…tionAuthRequestService
@r-tome
[AC-2302] Remove @Injectable() and manually configure dependencies
4731b71
@r-tome
[AC-2302] Add OrganizationAuthRequestService unit tests first draft
d7131fc
@r-tome
Merge branch 'main' into ac/ac-2302/move-device-approve-deny-into-a-s…
b67aee4 
…ervice
@r-tome
[AC-2302] Refactor device-approvals.component.ts to remove unused imp…
89fd1b3 
…orts
@r-tome
[AC-2302] Set up jest on bit-common and add unit tests for Organizati…
07da341 
…onAuthRequestService
@r-tome
[AC-2302] Add bit-common to jest.config.js
0a54cc1
@r-tome
[AC-2302] Update organizations.module.ts to include safeProviders dec…
c770970 
…lared in variable
@r-tome
[AC-2302] Remove services and views folders from bit-common
8e0e85b
@r-tome
[AC-2302] Define path mapping
503a84b
@addisonbeck
Adjust an import path
d9ab12c 
The import path of `PendingAuthRequestView` in
`OrganizationAuthRequestApiService` was pointing to the wrong place. I
think this file was just recently moved, and the import didn't get
updated.
@addisonbeck
Get paths working
231f41e
@eliykat
Fix import
c88f274
@eliykat
Update jest config to use ts-jest adn jsdom
7a108ad
@eliykat
Copy-paste path mappings from bit-web
9c00aa9
@eliykat
Remove unnecessary test setup file
d339a67
@eliykat
Undo unnecessary change
c6b5ed7
@eliykat
Fix remaining path mappings
7ffdeff
@eliykat
Remove Bitwarden License mapping from OSS code
5e66416
@eliykat
Fix bit-web so it uses its own tsconfig
db07fca
@eliykat
Fix import path
a5db3e4
@eliykat
Remove web-bit entrypoint from OSS tsconfig
b4365c7
@r-tome
Make DeviceApprovalsComponent standalone
3f3b178
@r-tome
Remove organization-auth-request-api.service export
ccad7ef
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 19, 2024 •
edited

Logo
Checkmarx One – Scan Summary & Details – ae4a0678-3352-4688-a32a-e24975f9cce6

No New Or Fixed Issues Found

@r-tome r-tome added the needs-qa Marks a PR as requiring QA approval label May 22, 2024
@r-tome r-tome requested a review from addisonbeck May 22, 2024 14:15
r-tome and others added 2 commits May 23, 2024 09:50
@r-tome r-tome requested a review from addisonbeck May 23, 2024 14:02
addisonbeck
addisonbeck previously approved these changes May 23, 2024
View reviewed changes
Base automatically changed from ac/ac-2303/implement-approveallrequests-method to main May 24, 2024 14:48
@r-tome r-tome dismissed addisonbeck’s stale review May 24, 2024 14:48

The base branch was changed.

@r-tome r-tome requested a review from addisonbeck May 24, 2024 14:55
@r-tome r-tome removed the needs-qa Marks a PR as requiring QA approval label May 27, 2024
@r-tome r-tome merged commit 8e7a215 into main May 27, 2024
32 checks passed
@r-tome r-tome deleted the ac/ac-1712/add-approve-all-devices-option branch May 27, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addisonbeck addisonbeck addisonbeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@r-tome @addisonbeck @eliykat