Cycle through every login when using the auto-fill shortcut #956
Conversation
|
Hi Kyle, can you answer my comments here? 🙂 |
|
@xusoo I have this on my backlog and will review when I get some time. Sorry for the delay. |
|
Ah ok, don’t worry then 👍
El 5 jul 2019 20:31 +0200, Kyle Spearrin <notifications@github.com>, escribió:
… @xusoo I have this on my backlog and will review when I get some time. Sorry for the delay.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
This would be a great feature! @xusoo is there anything you need help with or are we just waiting on review from @kspearrin ? I'm more than happy to help (I've made a few extensions before) if there is anything else to do here. |
|
Would just like to second the comments here @kspearrin offering help on this PR and that this would be an incredibly useful feature. In the process of switching over form 1Password, because I believe this has the potential to be so much better with community support, e.g. this PR |
|
Would love to see this -- in fact, any sort of "default" instead of just last used would be helpful, too. |
|
@xusoo did you ever hear back? @kspearrin have you had a chance to review? This is a highly coveted feature |
|
No @luckman212 I didn’t hear back 😅 |
|
|
|
Would love to see this feature released! |
|
what's preventing this from being being added? is it just the cla that needs signing? @xusoo? other than no soft delete, this one feature is preventing me from switching from 1password |
Oh, I signed it a while ago, I don't know what happened. I've signed it again anyway. But no, I don't think this was what kept this from being merged. There are still some open questions to @kspearrin from a year ago, I don't really know if I should make some changes to my code or what. By the way: https://github.com/bitwarden/browser/releases/tag/v1.44.0 (Soft delete) |
|
Oh thanks, didn't realise soft delete was added already Is this still on your radar @kspearrin ? |
|
this is an absolutely crucial feature that most mainstream password managers have integrated! Please make this happen :D |
|
@kspearrin just wanted to flag this again and volunteer to help with any work required to close out this PR. Can you comment on what still needs to be done? Thanks |
|
This feels pretty close folks, just a few tweaks and polyfill/backfill for Safari and we should be able to accept the PR. |
This would be amazing -- thank you for the continued efforts! |
To be used from browser extension when autofilling. Related PR: bitwarden/clients#956
xusoo
force-pushed
the
cycle-through-logins
branch
from
d5f31a9
to
34aaa78
Compare
There was a problem hiding this comment.
These look good, I'll approve but still need @kspearrin to clear final changes. Will need to wait for jslib updates before merging in/finalizing.
To be used from browser extension when autofilling. Related PR: bitwarden/clients#956
|
Thanks for keeping this one alive, love your work |
* Add new method for cycling through every login To be used from browser extension when autofilling. Related PR: bitwarden/clients#956 * Cache sorted ciphers by URL and invalidate them after a period of 5 seconds * Move file to models
|
@kspearrin can't wait to have this available in the Chrome extension! Any idea when you'll push a new release out? |
@luckman212 , our next major release will likely be coming in a matter of weeks, definitely in September. |
|
It's out! This is wonderful, thank you @xusoo, @kspearrin & @cscharf ❤️ |
|
Is it in 1.46.1? |
|
Yes it's in 1.46.1. I have my hotkey set to Cmd+S - it does cycle matching logins for me (macOS/Chrome85) |
|
@luckman212 Thanks, I have tested on the other website and it works! It does not on the other one, but sadly I can't share a link to it |
|
Great to see this released. However, I've had trouble with it on a few sites and hence raised issue #1392. I'm seeing a number of sites where the cycling gets stuck bouncing between 2 out of my many logins for a given site rather than going through them all. |
|
While this is a great feature, it could be a LOT better if 2 things were implemented:
|
|
I like both of those ideas. In fact, an argument could be made to make alpha order the default, with the first autofill being the most-recently-used and cycling alpha order after that. I suggest you create a new issue so that it's not buried in a merged PR. |
|
Thanks @kriswilk -- there's already an FR over here https://community.bitwarden.com/t/cycle-through-logins-alphabetically-browser-extension/28478 And, seems we can't open new FRs under GH Issues, it just forwards over to the Community Forums. Not sure how to call more attention to it. |
|
Well, I added my vote on the FR! |
I wanted to contribute with something to the project (besides the premium subscription) and I saw this open feature request so I decided to implement it myself 😄
Let me know any doubt, any problem or anything you see that could've been done in a better way 👍