This repository has been archived by the owner on Jul 23, 2022. It is now read-only.
Add credit card logos to allow displaying icons based on brand #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nusaarnio/master # Conflicts: # src/scss/styles.scss
|
|
djsmith85
approved these changes
Dec 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR 3/4 related to https://community.bitwarden.com/t/credit-card-logos-for-card-vault-items/33267
Type of change
Objective
Add images for the credit card logos.
Code changes
This PR adds the images needed by bitwarden/jslib#537.
They are a modified (changed size to look better in the 20x20 box for icons) version of https://www.figma.com/community/file/880472656109554171 which is licenced under CC BY 4.0 by Arthur Chayka
Screenshots
Testing requirements
Test that images are shown correctly for the different brands.
Test that no brands are shown when "Disable Website Icons" is checked in options.
Before you submit
npm run lint) (required)