Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRE-40 Add step to report upcoming release version to Slack #482

Merged
merged 2 commits into from
May 21, 2024

Conversation

urbinaalex17
Copy link
Contributor

@urbinaalex17 urbinaalex17 commented May 16, 2024

Type of change

- [ ] Bug fix
- [] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [X] Build/deploy pipeline (BRE)
- [ ] Other

Objective

Report upcoming release to Slack using the generate version bump by the workflow.

Related PR: bitwarden/gh-actions#281

Code changes

  • .github/workflows/version-bump.yml: Add step to report upcoming release

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@urbinaalex17 urbinaalex17 requested a review from a team as a code owner May 16, 2024 16:01
@bitwarden-bot
Copy link

bitwarden-bot commented May 16, 2024

Logo
Checkmarx One – Scan Summary & Detailsa88953d1-2272-46d9-bcc4-04b9df015c38

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 198 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

@urbinaalex17 urbinaalex17 self-assigned this May 20, 2024
@urbinaalex17 urbinaalex17 merged commit d1d4f53 into main May 21, 2024
14 checks passed
@urbinaalex17 urbinaalex17 deleted the task/BRE-40 branch May 21, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants