This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Fix URI vault regex example #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ypid
force-pushed
the
fix/uri-regex-alternative-patch
branch
from
defd5af
to
bdb09a7
Compare
ypid
changed the title
I find it important that examples actually follow best practices. The current regex does not escaping dots in URIs when writing regex is a mistake that is often made, even by advanced regex people. I think this comes from the way we humans look at URIs. Dots are so common in there, aren’t they? Yes, but we write proper regular expressions here, not something in between. Updates: bitwarden#41 Alternative: bitwarden#158 Replaces: bitwarden#160
ypid
force-pushed
the
fix/uri-regex-alternative-patch
branch
from
bdb09a7
to
6d32f5a
Compare
|
Both me and the rebase from #160 made a mistake that you noticed and I just fixed. Thanks! It does not prevent that and I updated the initial comment accordingly. |
|
Great! I'll approve & merge this PR, and then hop over to #158 |
fschillingeriv
approved these changes
Feb 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find it important that examples actually follow best practices. The current regex does not escaping dots in URIs when writing regex is a mistake that is often made, even by advanced regex people. I think this comes from the way we humans look at URIs. Dots are so common in there, aren’t they? Yes, but we write proper regular expressions here, not something in between.
Note: This is just a quick fix, please consider #158 (additionally)
Fixes: #392
Updates: #41
Full fix: #158
Replaces: #160