Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Add examples to clarify Host and Regular expression URI match behavior #41

Merged
merged 2 commits into from
Jan 31, 2019
Merged

Add examples to clarify Host and Regular expression URI match behavior #41

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e796d0
Add examples to clarify Host/Regular expression
gene1wood Jan 31, 2019
744f246
Revert the regex example and change the regex
gene1wood Jan 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions _articles/features/uri-match-detection.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ Example:

- URI host value: `https://sub.domain.com:4000`
- Matches: `http://sub.domain.com:4000`, `http://sub.domain.com:4000/page.html`
- Not matches: `https://domain.com`, `https://sub.domain.com`, `https://sub2.domain.com`, `https://sub.domain.com:5000`
- Not matches: `https://domain.com`, `https://sub.domain.com`, `https://sub2.domain.com`, `https://sub.domain.com:5000`, `http://sub2.sub.domain.com:4000`

**Starts with**

Expand All @@ -75,7 +75,7 @@ The regular expression option allows you to write any simple or complex [regular

Example:

- URI regex value: `^https://.*google.com`
- URI regex value: `^https://.*google.com$`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @ypid points out in #158 The regex as written

^https://.*google.com$

should actually be

^https://.*google\.com$

- Matches: `https://google.com`, `https://sub.google.com`, `https://sub.sub2.google.com`, `https://malicious-site.com?q=google.com`
- Not matches: `http://google.com` (not https), `https://yahoo.com`

Expand Down