This repository has been archived by the owner on Jun 17, 2022. It is now read-only.
Skip FirefoxAccounts during Firefox CSV Import #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox exports 'chrome://FirefoxAccounts' if Firefox Accouts are used in browser. It's quite hacky - password field in CSV is actually a JSON encoded data, not a password. Because it's not a useful record, it should be skipped during import.
|
|
cscharf
reviewed
Apr 5, 2021
There was a problem hiding this comment.
Thanks for the submission! Outside of some formatting issues I think this looks okay. Would like @MGibson1 to take a quick peek at the unit tests as well. Overall please ensure member/property indentation and level-alignment (using spaces only) matches across the board.
MGibson1
approved these changes
Apr 5, 2021
MGibson1
suggested changes
Apr 5, 2021
|
Sorry about reversing that approval! for some reason when I first clicked review it showed me only spacing fixes. 🤷 |
|
Test data is now in separate files, and this time I fixed all linter errors before commiting ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox exports
chrome://FirefoxAccountsif Firefox Accouts are used in browser. It's quite hacky - password field in CSV is actually a JSON encoded data, not a password.Because it's not a useful record, it should be skipped during import.
This PR adds filtering and unit test for Firefox importer.