Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

Resolve hasKeyStored returning true when no biometric key is stored #671

Merged
merged 4 commits into from Feb 11, 2022
Merged

Resolve hasKeyStored returning true when no biometric key is stored #671

merged 4 commits into from Feb 11, 2022

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Feb 11, 2022 •
edited

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

It seems hasKeyStored returned true when checking for biometric keys since hasCryptoMasterKeyBiometric returns a boolean which should never be null.

Should resolve bitwarden/clients#2334

Testing requirements

I've tested this in browser, but we probably need to investigate if this has sideeffects in the other clients.

Before you submit

  • I have checked for linting errors (npm run lint) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@Hinton Hinton requested a review from a team February 11, 2022 11:41
@djsmith85 djsmith85 merged commit fd0410c into master Feb 11, 2022
@djsmith85 djsmith85 deleted the hotfix/biometric-key-check branch February 11, 2022 12:17
djsmith85 added a commit to bitwarden/clients that referenced this pull request Feb 11, 2022
@djsmith85
Update jslib for bitwarden/jslib#671
de91850
@djsmith85 djsmith85 mentioned this pull request Feb 11, 2022
Merged
8 tasks
djsmith85 added a commit to bitwarden/clients that referenced this pull request Feb 11, 2022
@djsmith85
Update jslib for bitwarden/jslib#671 (#2352)
9d09923
djsmith85 pushed a commit that referenced this pull request Feb 11, 2022
@Hinton @djsmith85
Resolve hasKeyStored returning true when no biometric key is stored (#…
fc68136 
…671)

* Resolve hasKeyStored returning true when no biometric key is stored

* Change to use a switch statement which avoids having to fetch the key.

* Use triple equals

* Run prettier

(cherry picked from commit fd0410c)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cscharf cscharf cscharf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error: cannot decrypt on 1.56.0
3 participants
@Hinton @cscharf @djsmith85