Fixes and improvements to MykiCsvImporter

[djsmith85]

Type of change

• Bug fix
• New feature development
• Tech debt (refactoring, code cleanup, dependency upgrades, etc)
• Build/deploy pipeline (DevOps)
• Other

Objective

With the announcement of Myki discontinuing their existing products on April 10th, 2022, after being aquired by JumpCloud, it was time to revisit our Myki importer.

This PR fixes some minor issues and adds support for previously not imported exports types (UserIdCard.csv and UserTwoFA.csv).

Asana task: https://app.asana.com/0/1200578627114106/1201930330138516/f

Rough overview of imported ciphers/fields:

• Empty fields are skipped

• All unmapped columns are imported as custom fields (for example: status and tags)

• Login items - UserAccount.csv

  • Username
  • Password
  • TOTP
  • Notes

• TwoFA - UserTwoFa.csv

  • nickname -> CipherTitle
  • TOTP
  • Notes

• CreditCard items - UserCreditCard.csv

  • Cardholder
  • CC Number
  • CVV
  • Expiry date
  • Card brand is set using CC Number and only to our supported brands
  • Notes

• Secure Notes- UserNote.csv

  • Title
  • Content

• Identity items - UserIdentity.csv

  • Firstname
  • MiddleName
  • LastName
  • Email
  • Address
  • Notes

• IdCard items - UserIdCard.csv

  • All idCards are converted to Bitwarden identities.
  • FirstName
  • MiddleName
  • LastName
  • For Passport and Social Security the respective fields are used. All other types fill the LicenseNumber field
  • Notes

Code changes

• common/src/importers/mykiCsvImporter.ts:
  • Fixed 2fa seed not being copied on account records
  • Fixedx secure note title not being set
  • Added support for importing userIdCard.csv and userTwoFa.csv
  • Add importing of all unmapped columns into custom fields
• spec/common/importers/mykiCsvImporter.spec.ts: added test suite
• spec/common/importers/testData/mykiCsv/*: Example exports used for testing

Testing requirements

Ensure that items are imported as described

Before you submit

• I have checked for linting errors (npm run lint) (required)
• I have added unit tests where it makes sense to do so (encouraged but not required)
• This change requires a documentation update (notify the documentation team)
• This change has particular deployment requirements (notify the DevOps team)

[differsthecat]

I'm guessing MyKi doesn't have these id types?

[djsmith85]

It does have those idType but as there were no other good identity fields to map to, it uses the switch's default to map them to cipher.identity.licenseNumber

[differsthecat]

Left one question, but it looks good and I'm really digging all of the tests you've been adding!