Fix for vault timeout not firing on resume #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvolkgang
requested changes
Feb 13, 2022
| @@ -217,10 +217,9 @@ private async Task SleptAsync() | |||
|
|
|||
| private async void ResumedAsync() | |||
There was a problem hiding this comment.
Let's take the opportunity to change this to async Task and use the FireAndForget method @fedemkr added in a previous PR, logging exceptions.
fedemkr
approved these changes
Feb 14, 2022
vvolkgang
approved these changes
Feb 14, 2022
mpbw2
added a commit
that referenced
this pull request
Feb 14, 2022
* fix for vault timeout not firing on resume * call ResumedAsync with FireAndForget
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Fix for vault timeout not firing on app resume in most recent release. Closes #1772
Code changes
UpdateThemeasync resulted in a race condition which allowedBaseContentPage.SaveActivity()to execute prior toVaultTimeoutService.CheckVaultTimeoutAsync(). This resulted in theLastActiveTimevalue being reset before it could be compared to the current time, making the app think only a few milliseconds had passed regardless of how long it was in the background. By checking vault timeout before executing the improved theme update process, we're able to establish the correct elapsed time again. @fedemkr Let me know if you see any issues with this interfering with the theme updater.Testing requirements
Vault timeout should function as expected again.
Before you submit