Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-6846] Added spaced card nubmer to the card view #3084

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

moalhaddar
Copy link

@moalhaddar moalhaddar commented Mar 15, 2024

Type of change

  • [✅] Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

The card number in bitwarden mobile is not spaced in the mobile view. This pull request fixes the view such that the number is spaced in splits of 4.

Code changes

A new property in the CardView named SpacedNumber was added that adds a space in every 4 digits from the "CardView.Number"

@moalhaddar moalhaddar requested a review from a team as a code owner March 15, 2024 16:45
@CLAassistant
Copy link

CLAassistant commented Mar 15, 2024

CLA assistant check
All committers have signed the CLA.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-6846

@bitwarden-bot bitwarden-bot changed the title Added spaced card nubmer to the card view [PM-6846] Added spaced card nubmer to the card view Mar 15, 2024
@dfunkt dfunkt mentioned this pull request Mar 16, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants