Replaced accessibility service notification with in-line overlay. #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uires draw-over permission to be enabled (will prompt if not, though this will be enhanced in subsequent commits)
kspearrin
requested changes
Jan 9, 2020
| @@ -16,4 +16,13 @@ | |||
| <string name="PasswordGenerator"> | |||
| Password Generator | |||
| </string> | |||
| <string name="AccessibilityOverlayLine1"> | |||
There was a problem hiding this comment.
We should move these into AppResources so that they can be translated. We only use this strings file for a select few things that we cannot use AppResources for.
|
|
||
| public static LinearLayout GetOverlayView(Context context) | ||
| { | ||
| LayoutInflater inflater = (LayoutInflater)context.GetSystemService(Context.LayoutInflaterService); |
|
|
||
| public static Point GetOverlayAnchorPosition(AccessibilityNodeInfo root, AccessibilityEvent e) | ||
| { | ||
| Rect rootRect = new Rect(); |
| { | ||
| var activity = (MainActivity)CrossCurrentActivity.Current.Activity; | ||
|
|
||
| int barHeight = 0; |
| { | ||
| if(notificationManager == null || string.IsNullOrWhiteSpace(uri)) | ||
| if (!AccessibilityHelpers.OverlayPermitted(this)) |
There was a problem hiding this comment.
We need to adjust formatting settings to match.
| WindowManagerFlags.NotFocusable | WindowManagerFlags.NotTouchModal, | ||
| Android.Graphics.Format.Transparent); | ||
|
|
||
| Point anchorPosition = AccessibilityHelpers.GetOverlayAnchorPosition(root, e); |
|
|
||
| if(Build.VERSION.SdkInt > BuildVersionCodes.KitkatWatch) | ||
| Boolean updateView = false; |
| .SetContentIntent(pendingIntent); | ||
| if (_windowManager == null) | ||
| { | ||
| _windowManager = GetSystemService(WindowService).JavaCast<IWindowManager>(); |
There was a problem hiding this comment.
Never seen this JavaCast before. Is that different than a regular cast?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced accessibility service notification with in-line overlay. Requires draw-over permission to be enabled (will prompt if not, though this will be enhanced in subsequent commits)