Skip to content

Commit

Permalink
Remove some todos
Browse files Browse the repository at this point in the history
  • Loading branch information
dani-garcia committed May 24, 2024
1 parent 10fa9f7 commit 2a448bd
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
5 changes: 1 addition & 4 deletions crates/bitwarden/src/platform/fido2/authenticator.rs
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ impl<'a> Fido2Authenticator<'a> {
})
}

// TODO(Fido2): We need some changes in the passkey crate to do this
// TODO(Fido2): We need some changes in the passkey crate to do this correctly
pub async fn silently_discover_credentials(
&mut self,
rp_id: String,
Expand Down Expand Up @@ -281,7 +281,6 @@ impl passkey::authenticator::CredentialStore for CredentialStoreImpl<'_> {
cred: Passkey,
user: passkey::types::ctap2::make_credential::PublicKeyCredentialUserEntity,
rp: passkey::types::ctap2::make_credential::PublicKeyCredentialRpEntity,
// TODO(Fido2): Use this
_options: passkey::types::ctap2::get_assertion::Options,
) -> Result<(), StatusCode> {
// This is just a wrapper around the actual implementation to allow for ? error handling
Expand Down Expand Up @@ -407,8 +406,6 @@ impl passkey::authenticator::UserValidationMethod for UserValidationMethodImpl<'
&self,
hint: UIHint<'a, Self::PasskeyItem>,
presence: bool,
// TODO(Fido2): This is not used as we're using the UV stored in get_assertion and
// make_credential Should we validate that it matches with what we stored?
_verification: bool,
) -> Result<UserCheck, Ctap2Error> {
let verification = self
Expand Down
1 change: 0 additions & 1 deletion crates/bitwarden/src/platform/fido2/client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ impl<'a> Fido2Client<'a> {
raw_id: result.raw_id.into(),
ty: get_string_name_from_enum(result.ty)?,

Check warning on line 81 in crates/bitwarden/src/platform/fido2/client.rs

View check run for this annotation

Codecov / codecov/patch

crates/bitwarden/src/platform/fido2/client.rs#L81

Added line #L81 was not covered by tests

// TODO(Fido2): Had to change this type to Option, should we just use a default?
authenticator_attachment: result
.authenticator_attachment
.map(get_string_name_from_enum)
Expand Down

0 comments on commit 2a448bd

Please sign in to comment.