Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memory testing for asymmetric crypto keys #794

Merged
merged 1 commit into from
May 23, 2024
Merged

Add memory testing for asymmetric crypto keys #794

merged 1 commit into from
May 23, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented May 21, 2024

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Add memory testing for AsymmetricCryptoKey

Before you submit

  • Please add unit tests where it makes sense to do so

@Hinton Hinton requested a review from dani-garcia May 21, 2024 11:45
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details3b414a3b-4858-48db-b7d6-8356e9404d00

No New Or Fixed Issues Found

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.55%. Comparing base (0e3553a) to head (bcffcdd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #794   +/-   ##
=======================================
  Coverage   58.55%   58.55%           
=======================================
  Files         178      178           
  Lines       11544    11544           
=======================================
  Hits         6760     6760           
  Misses       4784     4784           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@Hinton Hinton merged commit 3c1e3c6 into main May 23, 2024
105 checks passed
@Hinton Hinton deleted the ps/mem-primes branch May 23, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants