[PM-8301] Create bitwarden-vault #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New Issues
Fixed Issues
|
# Conflicts: # crates/bitwarden-core/src/error.rs # crates/bitwarden-core/src/lib.rs # crates/bitwarden-core/src/uniffi_support.rs # crates/bitwarden-vault/src/cipher/cipher.rs # crates/bitwarden-vault/src/cipher/field.rs # crates/bitwarden-vault/src/cipher/login.rs # crates/bitwarden-vault/src/cipher/secure_note.rs # crates/bitwarden-vault/src/collection.rs # crates/bitwarden-vault/src/domain.rs # crates/bitwarden-vault/src/folder.rs # crates/bitwarden/src/error.rs # crates/bitwarden/src/tool/exporters/mod.rs # crates/bitwarden/src/vault/sync.rs
dani-garcia
previously approved these changes
Jun 10, 2024
crates/bitwarden-core/src/error.rs
Outdated
| @@ -4,6 +4,10 @@ use thiserror::Error; | |||
| #[error("The response received was missing a required field: {0}")] | |||
| pub struct MissingFieldError(pub &'static str); | |||
|
|
|||
| #[derive(Debug, Error)] | |||
| #[error("The client vault is locked and needs to be unlocked before use")] | |||
| pub struct VaultLocked(); | |||
There was a problem hiding this comment.
Nit: You can define the struct without parentheses and that way you don't need to use them every time you refer to this error type:
Suggested change
| pub struct VaultLocked(); | |
| pub struct VaultLocked; |
dani-garcia
approved these changes
Jun 10, 2024
michalchecinski
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-8301
📔 Objective
Continue extracting functionality from
bitwardento new crates.VaultLockedtobitwarden-core.bitwarden/src/vaultmodels tobitwarden-vaultcrate.⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes