[PM-8301] Create bitwarden-send #829
Conversation
crates/bitwarden-send/src/error.rs
Outdated
There was a problem hiding this comment.
This parse error is similar to CipherParseError, perhaps we should expose a generic ParseError in bitwarden-core?
There was a problem hiding this comment.
Do you mean VaultParseError? And yeah if it's going to be used in multiple places, I think sharing it would make sense.
|
New Issues
Fixed Issues
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #829 +/- ##
=======================================
Coverage 59.22% 59.22%
=======================================
Files 186 188 +2
Lines 12396 12403 +7
=======================================
+ Hits 7341 7346 +5
- Misses 5055 5057 +2 ☔ View full report in Codecov by Sentry. |
# Conflicts: # .github/workflows/publish-rust-crates.yml # Cargo.lock # Cargo.toml # crates/bitwarden/Cargo.toml # crates/bitwarden/src/error.rs
| struct MockKeyContainer(HashMap<Option<Uuid>, SymmetricCryptoKey>); | ||
| impl MockKeyContainer { | ||
| fn new(master_key: MasterKey, user_key: EncString) -> Result<Self, CryptoError> { | ||
| let user_key = master_key.decrypt_user_key(user_key)?; | ||
| Ok(Self(HashMap::from([(None, user_key)]))) | ||
| } | ||
| } | ||
| impl KeyContainer for MockKeyContainer { | ||
| fn get_key<'a>(&'a self, org_id: &Option<Uuid>) -> Option<&'a SymmetricCryptoKey> { | ||
| self.0.get(org_id) | ||
| } | ||
| } |
There was a problem hiding this comment.
I think long term we should consider extracting this into a test crate or something.
There was a problem hiding this comment.
Yeah I think a separate test crate, or maybe even just a dedicated test module in bitwarden-core would be helpful in the future
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-8301
📔 Objective
Extract send to separate crate.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes