Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename selected_credential to selected_cipher #832

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

dani-garcia
Copy link
Member

@dani-garcia dani-garcia commented Jun 11, 2024

๐Ÿ“” Objective

selected_credential is a misleading name as the selected value doesn't have to contain credentials, for example when creating a new passkey a cipher will usually not contain any credentials. Renaming it to selected_cipher should help clear the confusion a bit.

I've left the get_selected_credential function with the same name, as in this case we are actually getting the credential inside the cipher.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 85856970-9c90-46c9-bb99-6de731ca0e5d

No New Or Fixed Issues Found

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 59.23%. Comparing base (dfd0ba8) to head (e0953ff).

Files Patch % Lines
...ates/bitwarden/src/platform/fido2/authenticator.rs 0.00% 6 Missing โš ๏ธ
crates/bitwarden/src/platform/fido2/mod.rs 0.00% 1 Missing โš ๏ธ
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #832   +/-   ##
=======================================
  Coverage   59.23%   59.23%           
=======================================
  Files         186      186           
  Lines       12428    12428           
=======================================
  Hits         7362     7362           
  Misses       5066     5066           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@dani-garcia dani-garcia merged commit 47f4b1c into main Jun 11, 2024
105 checks passed
@dani-garcia dani-garcia deleted the ps/rename-selected-credential branch June 11, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants