Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove calls to client_settings namespace #848

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jun 14, 2024

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

Now that we expose ClientSettings and DeviceType directly in the root bitwarden crate we can make the client_settings module private. I also added README files to the newly created crates that missed them.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@Hinton Hinton requested a review from dani-garcia June 14, 2024 15:46
Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 9e003674-4ab4-47c2-820f-efa465ab94cd

No New Or Fixed Issues Found

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 60.30%. Comparing base (32ac1e4) to head (ecf0ddb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #848   +/-   ##
=======================================
  Coverage   60.30%   60.30%           
=======================================
  Files         189      189           
  Lines       12361    12361           
=======================================
  Hits         7454     7454           
  Misses       4907     4907           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@Hinton Hinton merged commit 444ee1b into main Jun 17, 2024
104 checks passed
@Hinton Hinton deleted the ps/client-settings-housekeeping branch June 17, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants