Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account revision date not bumped with EntityFramework DBs #2615

Closed
1 task done
Tracked by #2480
M1cha opened this issue Jan 23, 2023 · 0 comments · Fixed by #2634
Closed
1 task done
Tracked by #2480

account revision date not bumped with EntityFramework DBs #2615

M1cha opened this issue Jan 23, 2023 · 0 comments · Fixed by #2634
Labels
bug bw-unified-deploy An Issue related to Bitwarden unified deployment

Comments

@M1cha
Copy link
Contributor

M1cha commented Jan 23, 2023

Steps To Reproduce

  1. setup the mariadb sample
  2. connect a desktop client and an android client
  3. create a new password(cipher) using desktop

Expected Result

Android will see the new entry. If not automatically it should at least show up after a manual sync.

Actual Result

The entry will not show up until logging out and back in again. A manual sync doesn't help.

Screenshots or Videos

No response

Additional Context

I took look at the communication using tcpdump+wireshark and it looks like the only thing Android ever does is poll GET /accounts/revision-date.
That date does not change after creating a new password though.

I assume that unlike desktop, Android uses the date exclusively to decide if a sync is needed. So since that's never being updated by the server you'll never see any updates until you log out and back in again.

Githash Version

3997def-dirty

Environment Details

  • Operating System: Fedora CoreOS
  • Container runtime: podman
  • Hardware: RK3399 SBC (arm64)

mariadb container: https://github.com/M1cha/homeserver/blob/284054030b76e8faf4a3b5749e491157b6623c55/files/containers/bitwarden-mariadb.container
bitwarden container: https://github.com/M1cha/homeserver/blob/284054030b76e8faf4a3b5749e491157b6623c55/files/containers/bitwarden.container

Database Image

docker.io/mariadb:10

Issue-Link

#2480

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
@M1cha M1cha added bug bw-unified-deploy An Issue related to Bitwarden unified deployment labels Jan 23, 2023
@M1cha M1cha changed the title account revision date not bumped with mariadb account revision date not bumped with EntityFramework DBs Jan 26, 2023
M1cha added a commit to M1cha/bitwarden-server that referenced this issue Jan 26, 2023
When the user is not part of an organization,
`UserBumpAccountRevisionDateByCipherIdQuery` doesn't work. In that case
we have to use `UserBumpAccountRevisionDateAsync` instead.

This was already done by most parts of the code but a few more were
missing.

Fixes bitwarden#2615
M1cha added a commit to M1cha/bitwarden-server that referenced this issue Feb 2, 2023
When the user is not part of an organization,
`UserBumpAccountRevisionDateByCipherIdQuery` doesn't work. In that case
we have to use `UserBumpAccountRevisionDateAsync` instead.

This was already done by most parts of the code but a few more were
missing.

Fixes bitwarden#2615
M1cha added a commit to M1cha/bitwarden-server that referenced this issue Feb 2, 2023
When the user is not part of an organization,
`UserBumpAccountRevisionDateByCipherIdQuery` doesn't work. In that case
we have to use `UserBumpAccountRevisionDateAsync` instead.

This was already done by most parts of the code but a few more were
missing.

Fixes bitwarden#2615
justindbaur pushed a commit that referenced this issue Feb 2, 2023
…2634)

When the user is not part of an organization,
`UserBumpAccountRevisionDateByCipherIdQuery` doesn't work. In that case
we have to use `UserBumpAccountRevisionDateAsync` instead.

This was already done by most parts of the code but a few more were
missing.

Fixes #2615
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bw-unified-deploy An Issue related to Bitwarden unified deployment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant