Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EC-177 EC-178] Add uid.env to key-connector compose config #2005

Merged
merged 1 commit into from May 20, 2022
Merged

[EC-177 EC-178] Add uid.env to key-connector compose config #2005

merged 1 commit into from May 20, 2022

Conversation

eliykat
Copy link
Member

@eliykat eliykat commented May 19, 2022

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Key Connector does not include uid.env in its environment configuration. This means that the uid of the user inside the container is not set properly, and it causes errors when accessing mounted files.

This brings KC into line with the configuration of other containers.

Code changes

As above

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • If making database changes - I have also updated Entity Framework queries and/or migrations
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@eliykat eliykat requested a review from kspearrin May 19, 2022 04:45
@eliykat eliykat changed the title Add uid.env to key-connector compose config [EC-177 EC-178] Add uid.env to key-connector compose config May 19, 2022
@eliykat eliykat requested a review from a team May 19, 2022 21:32
@eliykat eliykat merged commit 98546a6 into master May 20, 2022
@eliykat eliykat deleted the fix/kc-env branch May 20, 2022 01:31
MGibson1 pushed a commit that referenced this pull request May 26, 2022
@eliykat @MGibson1
Add uid.env to key-connector compose config (#2005)
41096e0 
(cherry picked from commit 98546a6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kspearrin kspearrin kspearrin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eliykat @kspearrin