Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target proper alpine binaries for hbs tool #2441

Merged
merged 1 commit into from Nov 24, 2022
Merged

target proper alpine binaries for hbs tool #2441

merged 1 commit into from Nov 24, 2022

Conversation

kspearrin
Copy link
Member

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

I noticed hbs was not working on my Pi 3 machine. We need proper alpine compatible binaries for the hbs tool we are using to generate templated config files. This build adjusts the Dockerfile to pull the proper binaries.

Code changes

  • Dockerfile: Target hbs v1.3.0 alpine binaries.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@kspearrin kspearrin requested review from vgrassia and a team November 24, 2022 04:53
@kspearrin kspearrin merged commit 4c5b773 into master Nov 24, 2022
@kspearrin kspearrin deleted the hbsalpine branch November 24, 2022 18:16
kspearrin added a commit that referenced this pull request Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants